lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:   Mon, 15 Nov 2021 18:47:13 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Karolina Drobnik <karolinadrobnik@...il.com>
Cc:     outreachy-kernel@...glegroups.com, gregkh@...uxfoundation.org,
        forest@...ttletooquiet.net, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 0/8] staging: vt6655: Fix line wrapping in
 `RFvWriteWakeProgSyn`

On Mon, Nov 15, 2021 at 10:55:41AM +0000, Karolina Drobnik wrote:
>   * merge two patches (using incrementation in `idx` and cleanup) into one,
>     partially implementing Dan's suggestion

Reviewed-by: Dan Carpenter <dan.carpenter@...cle.com>

I don't know why you didn't implement my suggestions exactly as I
described.... :/

If I were reading this patchset the first time through I would have
NAKed it because patch 2 is done in the wrong way.  In a way, it's my
fault because I tried to explain exactly how the one thing per patch
rule worked and I obviously was not clear.

Ah well...  Let's just merge it and move on.

regards,
dan carpenter

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ