linux-kernel - Re: [PATCH] block: Use REQ_OP_WRITE instead of its integer constant 1 in op_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2a239998-2bab-c1ad-dcb9-6e51c8a5d05f@nvidia.com>
Date:   Tue, 16 Nov 2021 01:30:11 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Bean Huo <huobean@...il.com>
CC:     Bean Huo <beanhuo@...ron.com>, "axboe@...nel.dk" <axboe@...nel.dk>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] block: Use REQ_OP_WRITE instead of its integer constant 1
 in op_is_write()

Bean,

>   static inline bool op_is_write(unsigned int op)
>   {
> -       return (op & 1);
> +       return (op & REQ_OP_WRITE);
>   }

As pointed out by Damien it supposed to indicate data out and not
only write request REQ_OP_WRITE.

> 
>   /*
> --
> 2.25.1
>