linux-kernel - Re: [PATCH] blk-iocost: drop selecting undefined BLK_RQ_IO_DATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 15 Nov 2021 11:38:02 -1000
From:   Tejun Heo <tj@...nel.org>
To:     Lukas Bulwahn <lukas.bulwahn@...il.com>
Cc:     Jens Axboe <axboe@...nel.dk>, linux-block@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] blk-iocost: drop selecting undefined BLK_RQ_IO_DATA_LEN

On Fri, Nov 12, 2021 at 10:37:28AM +0100, Lukas Bulwahn wrote:
> Commit cd006509b0a9 ("blk-iocost: account for IO size when testing
> latencies") selects the non-existing config BLK_RQ_IO_DATA_LEN in
> config BLK_CGROUP_IOCOST.
> 
> Hence, ./scripts/checkkconfigsymbols.py warns:
> 
>   BLK_RQ_IO_DATA_LEN
>   Referencing files: block/Kconfig
> 
> Probably, this select is just some unintended left-over from an earlier
> draft version; BLK_RQ_IO_DATA_LEN was never defined in any commit in the
> repository. So, drop this dead select to an undefined config.
> 
> Fixes: cd006509b0a9 ("blk-iocost: account for IO size when testing latencies")
> Signed-off-by: Lukas Bulwahn <lukas.bulwahn@...il.com>

Acked-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun