linux-kernel - linux-next: build failure after merge of the cifs tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211116091702.3e2c4550@canb.auug.org.au>
Date:   Tue, 16 Nov 2021 09:17:02 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     Steve French <smfrench@...il.com>,
        CIFS <linux-cifs@...r.kernel.org>
Cc:     chiminghao <chi.minghao@....com.cn>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: linux-next: build failure after merge of the cifs tree

Hi all,

After merging the cifs tree, today's linux-next build (powerpc
ppc64_defconfig) failed like this:

In file included from fs/cifs/dns_resolve.c:18:
fs/cifs/cifsglob.h: In function 'cifs_get_tlink':
fs/cifs/cifsglob.h:1169:14: error: passing argument 1 of 'atomic_inc' from incompatible pointer type [-Werror=incompatible-pointer-types]
 1169 |   atomic_inc(&tlink->tl_count);
      |              ^~~~~~~~~~~~~~~~
      |              |
      |              refcount_t * {aka struct refcount_struct *}
In file included from include/linux/atomic.h:82,
                 from include/linux/cpumask.h:13,
                 from include/linux/smp.h:13,
                 from include/linux/lockdep.h:14,
                 from include/linux/spinlock.h:62,
                 from include/linux/mmzone.h:8,
                 from include/linux/gfp.h:6,
                 from include/linux/slab.h:15,
                 from fs/cifs/dns_resolve.c:15:
include/linux/atomic/atomic-instrumented.h:179:22: note: expected 'atomic_t *' but argument is of type 'refcount_t *' {aka 'struct refcount_struct *'}
  179 | atomic_inc(atomic_t *v)
      |            ~~~~~~~~~~^

and lots more similar ...

Caused by commit

  ef242296e441 ("fs:cifs: convert from atomic_t to refcount_t on tlink->tl_count")

Please write, review, test (repeat) and, only then, publish. :-(

I have used the cifs tree from next-20211115 for today.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped