linux-kernel - Re: [PATCH v3 7/7] spi: dw: Define the capabilities in a continuous bit-flags set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211116113209.n5njzklgh3fmbwwe@mobilestation>
Date:   Tue, 16 Nov 2021 14:32:09 +0300
From:   Serge Semin <fancer.lancer@...il.com>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Serge Semin <Sergey.Semin@...kalelectronics.ru>,
        Mark Brown <broonie@...nel.org>,
        Nandhini Srikandan <nandhini.srikandan@...el.com>,
        Andy Shevchenko <andy@...nel.org>, linux-spi@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 7/7] spi: dw: Define the capabilities in a continuous
 bit-flags set

On Tue, Nov 16, 2021 at 12:13:07PM +0200, Andy Shevchenko wrote:
> On Mon, Nov 15, 2021 at 09:19:17PM +0300, Serge Semin wrote:
> > Since the DW_SPI_CAP_DWC_HSSI capability has just been replaced with using
> > the DW SSI IP-core versions interface, the DW SPI capability flags are now
> > represented with a gap. Let's fix it by redefining the DW_SPI_CAP_DFS32
> > macro to setting BIT(2) of the capabilities field.
> > 
> > Signed-off-by: Serge Semin <Sergey.Semin@...kalelectronics.ru>
> > Suggested-by: Andy Shevchenko <andy.shevchenko@...il.com>
> 

> Fine with me, thanks!
> Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

Great! Thanks to you too for very fast responses and thorough review.

-Sergey

> 
> > ---
> > 
> > Changelog v3:
> > - This is a new patch unpinned from the previous one as of Andy
> >   suggested.
> > ---
> >  drivers/spi/spi-dw.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/spi/spi-dw.h b/drivers/spi/spi-dw.h
> > index 8334e6b35f89..d5ee5130601e 100644
> > --- a/drivers/spi/spi-dw.h
> > +++ b/drivers/spi/spi-dw.h
> > @@ -32,7 +32,7 @@
> >  /* DW SPI controller capabilities */
> >  #define DW_SPI_CAP_CS_OVERRIDE		BIT(0)
> >  #define DW_SPI_CAP_KEEMBAY_MST		BIT(1)
> > -#define DW_SPI_CAP_DFS32		BIT(3)
> > +#define DW_SPI_CAP_DFS32		BIT(2)
> >  
> >  /* Register offsets (Generic for both DWC APB SSI and DWC SSI IP-cores) */
> >  #define DW_SPI_CTRLR0			0x00
> > -- 
> > 2.33.0
> > 
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
>