linux-kernel - Re: [PATCH v11 0/2] Update ASUS WMI supported boards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 16 Nov 2021 06:32:10 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Andy Shevchenko <andy.shevchenko@...il.com>
Cc:     Denis Pauk <pauk.denis@...il.com>,
        Eugene Shalygin <eugene.shalygin@...il.com>,
        Platform Driver <platform-driver-x86@...r.kernel.org>,
        thomas@...ssschuh.net, Ed Brindley <kernel@...davale.org>,
        Jean Delvare <jdelvare@...e.com>,
        Jonathan Corbet <corbet@....net>, linux-hwmon@...r.kernel.org,
        Linux Documentation List <linux-doc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v11 0/2] Update ASUS WMI supported boards

On 11/16/21 2:38 AM, Andy Shevchenko wrote:
> On Mon, Nov 15, 2021 at 03:15:39PM -0800, Guenter Roeck wrote:
>> On 11/15/21 2:01 PM, Andy Shevchenko wrote:
>>> On Mon, Nov 15, 2021 at 11:09 PM Denis Pauk <pauk.denis@...il.com> wrote:
>>>>
>>>> Add support by WMI interface provided by Asus for B550/X570 boards:
>>>> * PRIME X570-PRO,
>>>> * ROG CROSSHAIR VIII HERO
>>>> * ROG CROSSHAIR VIII DARK HERO
>>>> * ROG CROSSHAIR VIII FORMULA
>>>> * ROG STRIX X570-E GAMING
>>>> * ROG STRIX B550-I GAMING
>>>> * ROG STRIX B550-E GAMING
>>>>
>>>> Add support by WMI interface provided by Asus for X370/X470/
>>>> B450/X399 boards:
>>>> * ROG CROSSHAIR VI HERO,
>>>> * PRIME X399-A,
>>>> * PRIME X470-PRO,
>>>> * ROG CROSSHAIR VI EXTREME,
>>>> * ROG CROSSHAIR VI HERO (WI-FI AC),
>>>> * ROG CROSSHAIR VII HERO,
>>>> * ROG CROSSHAIR VII HERO (WI-FI),
>>>> * ROG STRIX Z390-F GAMING
>>>> * ROG STRIX B450-E GAMING,
>>>> * ROG STRIX B450-F GAMING,
>>>> * ROG STRIX B450-I GAMING,
>>>> * ROG STRIX X399-E GAMING,
>>>> * ROG STRIX X470-F GAMING,
>>>> * ROG STRIX X470-I GAMING,
>>>> * ROG ZENITH EXTREME,
>>>> * ROG ZENITH EXTREME ALPHA.
>>>>
>>>> I have added "ROG STRIX Z390-F GAMING" to list of supported boards in
>>>> asus_wmi_sensors.
>>>
>>> Guenter, what is your plan about this patch series? It seems it
>>> missed, by unknown (?) reason, the v5.16-rc1 (I remember seeing it in
>>> some of your tree branches at some point).
>>>
>>
>> I don't see it in my record. Earlier I was simply waiting for some
>> Reviewed-by: tags, which I have never seen.
> 
> Ah, understood. Thank you for clarifications.
> 
>> Looking into the commit log,
>> I do see:
>>
>> Signed-off-by: Denis Pauk <pauk.denis@...il.com>
>> Co-developed-by: Eugene Shalygin <eugene.shalygin@...il.com>
>> Signed-off-by: Eugene Shalygin <eugene.shalygin@...il.com>
>> Co-developed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>>
>> Did you and Eugene indeed sign this off, ie did you write it, and
>> Eugene and Denis signed it off ? If so, the tags are in the wrong order.
> 
> I'm not sure I follow. I have helped Denis with the code and according to
> Submitting Patches documentation the order should be chronological with the
> main author to be first in the list. Here the committer (submitter) is the
> same as the original author IIUC. (I can't speak for Eugene, though)
> 

I got the patch from Denis. At the very least, Denis' signature should be
last. It is first.

Guenter

>> On the other side, if the code is ultimately from Denis, with your input,
>> the tags should be either Acked-by: or Reviewed-by: for both Eugene
>> and yourself.
> 
> I'm fine with either Co-developed-by+SoB or Reviewed-by.
> 
>> Note that v11 of this patch series is missing from
>> https://patchwork.kernel.org/project/linux-hwmon/list/
>> for some reason.
> 
> Hmm... Denis, please check locally how you prepare your patches.
> 
>