linux-kernel - Re: [PATCH v2 1/2] scripts: ftrace - move the sort-processing in ftrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7c7b26fa-81da-4e5a-1c3f-0a3fc44ac34e@linux.alibaba.com>
Date:   Tue, 16 Nov 2021 22:46:10 +0800
From:   Yinan Liu <yinan@...ux.alibaba.com>
To:     Peter Zijlstra <peterz@...radead.org>
Cc:     rostedt@...dmis.org, mark-pk.tsai@...iatek.com, mingo@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] scripts: ftrace - move the sort-processing in
 ftrace_init to compile time


>>> Also, can't sorttable be ran on modules ?
>>
>> The .ko file will be relocated after insmod or modprobe.
>> And the mcount redirection in .ko is based on ".text",
>> ".init.text", ".ref.text", ".sched.text", ".spinlock.text",
>> ".irqentry .text", ".softirqentry.text", ".kprobes.text", ".cpuidle.text",
>> ".text.unlikely". These sections‘ loading
>> position are not in definite order.
>>
>> So sorting this part at compile time doesn't make much sense.
> 
> Bah.. I thought the sections would retain relative position at least,
> but alas. if that isn't done you're quite right that sorting seems
> pointless.
> 

I found the problem when I was sorting mcount in .ko.
Initially I found that some mcount's relocation base on.text
and some base on .init.text.I tried insmod the same .ko several
times. The results show that there is no definite order between
the two sections，and the same situation occurs in several other
mcount base sections.





Best regards!
--Yinan liu