linux-kernel - Re: [PATCH v2 2/2] scripts: ftrace - move the nop-processing in ftrace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2ff387d4-e7e8-9407-802c-e1cfcb2ca511@linux.alibaba.com>
Date:   Tue, 16 Nov 2021 23:02:16 +0800
From:   Yinan Liu <yinan@...ux.alibaba.com>
To:     Steven Rostedt <rostedt@...dmis.org>,
        Peter Zijlstra <peterz@...radead.org>
Cc:     mark-pk.tsai@...iatek.com, mingo@...hat.com,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] scripts: ftrace - move the nop-processing in
 ftrace_init to compile time

在 2021/11/16 下午9:07, Steven Rostedt 写道:
> On Tue, 16 Nov 2021 09:10:20 +0100
> Peter Zijlstra <peterz@...radead.org> wrote:
> 
>> On Tue, Nov 16, 2021 at 10:49:42AM +0800, Yinan Liu wrote:
>>> In some business scenarios, GCC versions are so old that
>>> optimizations in ftrace cannot be completed, such as
>>> -mrecord-mcount and -mnop-mcount. The recordmCount in the
>>> kernel is actually used. In this case, ftrace_init will
>>> consume a period of time, usually around 9~12ms. Do nop
>>> substitution in recordmcount.c to speed up ftrace_init.
>>
>> I really don't buy this.. if you can build a fresh kernel, you can
>> install a fresh gcc too -- and if you care about performance that's a
>> very good idea anyway.
>>
> 
> I'm not sure this is true for all archs, is it? That is, is the nop
> substitution available in all archs that support mcount updates. Some
> (most) archs are special, because they have to deal with link registers and
> such.
> 
> And because of that, I'm not sure the patch works for all those archs.
> 
> -- Steve
> 

At present, I have only verified it under x86. In other cases, I am 
short of arch or scenarios. I am not sure whether the patch is 
applicable to all the architectures, perhaps adding something to x86?
Do you think it makes sense?

In fact, many companies cannot upgrade GCC due to online business 
reasons. This patch will help.




Best regards!
--Yinan liu