linux-kernel - Re: [PATCH v2 1/2] tracing: Add helper functions to simplify event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211116164120.0db8212b@gandalf.local.home>
Date:   Tue, 16 Nov 2021 16:41:20 -0500
From:   Steven Rostedt <rostedt@...dmis.org>
To:     Tom Zanussi <zanussi@...nel.org>
Cc:     mhiramat@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] tracing: Add helper functions to simplify
 event_command callback handling

On Fri, 12 Nov 2021 14:23:39 -0600
Tom Zanussi <zanussi@...nel.org> wrote:

>  
> +int event_trigger_check(char *glob, char **trigger, char **param,
> +			bool *remove, bool require_param, bool separate_trigger)

All these functions are going to require having kerneldoc comments for
them. I rather not have to try to figure out what these functions are for
and just read the documentation.

-- Steve


> +{
> +	int ret = 0;
> +
> +	*remove = (glob && glob[0] == '!') ? true : false;
> +