linux-kernel - Re: [PATCH v2 1/2] tracing: Add helper functions to simplify event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7d7de7ce5b6e6ab4ae497495f86ad65d86a613dc.camel@kernel.org>
Date:   Tue, 16 Nov 2021 15:59:01 -0600
From:   Tom Zanussi <zanussi@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     mhiramat@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] tracing: Add helper functions to simplify
 event_command callback handling

On Tue, 2021-11-16 at 16:41 -0500, Steven Rostedt wrote:
> On Fri, 12 Nov 2021 14:23:39 -0600
> Tom Zanussi <zanussi@...nel.org> wrote:
> 
> >  
> > +int event_trigger_check(char *glob, char **trigger, char **param,
> > +			bool *remove, bool require_param, bool
> > separate_trigger)
> 
> All these functions are going to require having kerneldoc comments
> for
> them. I rather not have to try to figure out what these functions are
> for
> and just read the documentation.

Yeah, that make sense, will add documention for each one in the next
version.

Thanks,

Tom

> 
> -- Steve
> 
> 
> > +{
> > +	int ret = 0;
> > +
> > +	*remove = (glob && glob[0] == '!') ? true : false;
> > +