linux-kernel - Re: [PATCH] PCI: mt7621: declare 'mt7621_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YZVwtUO/j/ZYaL3q@rocinante>
Date:   Wed, 17 Nov 2021 22:14:29 +0100
From:   Krzysztof Wilczyński <kw@...ux.com>
To:     Sergio Paracuellos <sergio.paracuellos@...il.com>
Cc:     linux-pci@...r.kernel.org, lorenzo.pieralisi@....com,
        bhelgaas@...gle.com, linux-kernel@...r.kernel.org,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] PCI: mt7621: declare 'mt7621_pci_ops' static

Hi,

> Sparse complains about 'mt7621_pci_ops' symbol is not declared and asks if
> it should be declared as 'static' instead. Sparse is right. Hence declare
> symbol as static.

Thank you for taking care of this!

[...]
> -struct pci_ops mt7621_pci_ops = {
> +static struct pci_ops mt7621_pci_ops = {
>  	.map_bus	= mt7621_pcie_map_bus,
>  	.read		= pci_generic_config_read,
>  	.write		= pci_generic_config_write,

Thank you!

Reviewed-by: Krzysztof Wilczyński <kw@...ux.com>

	Krzysztof