linux-kernel - Re: [PATCH] PCI: mt7621: declare 'mt7621_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMhs-H9KQbW=SQCyuR4008NPt8dWpGYspHTwJRRAeoi7Z1ygRg@mail.gmail.com>
Date:   Thu, 18 Nov 2021 06:08:21 +0100
From:   Sergio Paracuellos <sergio.paracuellos@...il.com>
To:     Krzysztof Wilczyński <kw@...ux.com>
Cc:     linux-pci <linux-pci@...r.kernel.org>,
        Lorenzo Pieralisi <lorenzo.pieralisi@....com>,
        Bjorn Helgaas <bhelgaas@...gle.com>,
        linux-kernel <linux-kernel@...r.kernel.org>,
        kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] PCI: mt7621: declare 'mt7621_pci_ops' static

Hi Krzysztof,

On Wed, Nov 17, 2021 at 10:14 PM Krzysztof Wilczyński <kw@...ux.com> wrote:
>
> Hi,
>
> > Sparse complains about 'mt7621_pci_ops' symbol is not declared and asks if
> > it should be declared as 'static' instead. Sparse is right. Hence declare
> > symbol as static.
>
> Thank you for taking care of this!
>
> [...]
> > -struct pci_ops mt7621_pci_ops = {
> > +static struct pci_ops mt7621_pci_ops = {
> >       .map_bus        = mt7621_pcie_map_bus,
> >       .read           = pci_generic_config_read,
> >       .write          = pci_generic_config_write,
>
> Thank you!
>
> Reviewed-by: Krzysztof Wilczyński <kw@...ux.com>

Thanks!

Best regards,
     Sergio Paracuellos

>
>         Krzysztof