linux-kernel - Re: [PATCH] perf/test: Test case 27 broken on s390 in linux-next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d8943b3f-b2d5-8b5c-cbf9-14360a6df2b4@linux.ibm.com>
Date:   Wed, 17 Nov 2021 14:00:48 +0530
From:   Madhavan Srinivasan <maddy@...ux.ibm.com>
To:     Arnaldo Carvalho de Melo <acme@...nel.org>,
        Thomas Richter <tmricht@...ux.ibm.com>
Cc:     linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
        sumanthk@...ux.ibm.com, jolsa@...hat.com, svens@...ux.ibm.com,
        gor@...ux.ibm.com, hca@...ux.ibm.com
Subject: Re: [PATCH] perf/test: Test case 27 broken on s390 in linux-next


On 11/7/21 01:02, Arnaldo Carvalho de Melo wrote:
> Em Wed, Nov 03, 2021 at 04:52:15PM +0100, Thomas Richter escreveu:
>> Commit 10269a2ca2b08c ("perf test sample-parsing: Add endian test for struct branch_flags")
>> broke the test case 27 (Sample parsing) on s390 on linux-next tree:
> Maddy,
>
> 	Can you please ack this one?

Sorry i missed this completely. My bad. Will check it and will reply.

Maddy


>
> - Arnaldo
>   
>>    # ./perf test -Fv 27
>>    27: Sample parsing
>>    --- start ---
>>    parsing failed for sample_type 0x800
>>    ---- end ----
>>    Sample parsing: FAILED!
>>    #
>>
>> The cause of the failure is a wrong #define BS_EXPECTED_BE statement
>> in above commit.  Correct this define and the test case runs fine.
>>
>> Output After:
>>    # ./perf test -Fv 27
>>    27: Sample parsing                                                  :
>>    --- start ---
>>    ---- end ----
>>    Sample parsing: Ok
>>    #
>>
>> Fixes: 10269a2ca2b08c ("perf test sample-parsing: Add endian test for struct branch_flags")
>> Signed-off-by: Thomas Richter <tmricht@...ux.ibm.com>
>> ---
>>   tools/perf/tests/sample-parsing.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/perf/tests/sample-parsing.c b/tools/perf/tests/sample-parsing.c
>> index c83a11514129..9c7af55b74db 100644
>> --- a/tools/perf/tests/sample-parsing.c
>> +++ b/tools/perf/tests/sample-parsing.c
>> @@ -36,7 +36,7 @@
>>    * These are based on the input value (213) specified
>>    * in branch_stack variable.
>>    */
>> -#define BS_EXPECTED_BE	0xa00d000000000000
>> +#define BS_EXPECTED_BE	0xa000d00000000000
>>   #define BS_EXPECTED_LE	0xd5000000
>>   #define FLAG(s)	s->branch_stack->entries[i].flags
>>   
>> -- 
>> 2.25.1