linux-kernel - Re: [PATCH 2/2] misc: Add iop driver for Sunplus SP7021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YZTDCG6bTjh7BoUH@kroah.com>
Date:   Wed, 17 Nov 2021 09:53:28 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Tony Huang <tonyhuang.sunplus@...il.com>
Cc:     robh+dt@...nel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, derek.kiernan@...inx.com,
        dragan.cvetic@...inx.com, arnd@...db.de, wells.lu@...plus.com,
        Tony Huang <tony.huang@...plus.com>
Subject: Re: [PATCH 2/2] misc: Add iop driver for Sunplus SP7021

On Wed, Nov 17, 2021 at 02:48:07PM +0800, Tony Huang wrote:
> Add iop driver for Sunplus SP7021
> 
> Signed-off-by: Tony Huang <tony.huang@...plus.com>

Along with everything that Arnd said, one more thing:

> +#define IOP_KDBG_INFO
> +#define IOP_FUNC_DEBUG
> +#define IOP_KDBG_ERR
> +#ifdef IOP_KDBG_INFO
> +	#define FUNC_DEBUG()	pr_info("K_IOP: %s(%d)\n", __func__, __LINE__)
> +#else
> +	#define FUNC_DEBUG()
> +#endif

This should just be deleted entirely, use ftrace if you want to see what
your kernel driver is doing.

No single driver should have special debugging macros like this, use the
kernel-wide system please.

This driver code can get a lot smaller after you make these cleanups.
Also be sure to use scripts/checkpatch.pl to remove the issues that it
points out so we don't have to say the same thing.

thanks,

greg k-h