linux-kernel - RE: [PATCH 2/2] misc: Add iop driver for Sunplus SP7021

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b7c8ac630615417cbf3e62e165067918@sphcmbx02.sunplus.com.tw>
Date:   Wed, 17 Nov 2021 09:17:34 +0000
From:   Tony Huang 黃懷厚 <tony.huang@...plus.com>
To:     Greg KH <gregkh@...uxfoundation.org>,
        Tony Huang <tonyhuang.sunplus@...il.com>
CC:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "derek.kiernan@...inx.com" <derek.kiernan@...inx.com>,
        "dragan.cvetic@...inx.com" <dragan.cvetic@...inx.com>,
        "arnd@...db.de" <arnd@...db.de>,
        Wells Lu 呂芳騰 <wells.lu@...plus.com>
Subject: RE: [PATCH 2/2] misc: Add iop driver for Sunplus SP7021

Dear greg k-h:

> -----Original Message-----
> From: Greg KH <gregkh@...uxfoundation.org>
> Sent: Wednesday, November 17, 2021 4:53 PM
> To: Tony Huang <tonyhuang.sunplus@...il.com>
> Cc: robh+dt@...nel.org; devicetree@...r.kernel.org;
> linux-kernel@...r.kernel.org; derek.kiernan@...inx.com;
> dragan.cvetic@...inx.com; arnd@...db.de; Wells Lu 呂芳騰
> <wells.lu@...plus.com>; Tony Huang 黃懷厚 <tony.huang@...plus.com>
> Subject: Re: [PATCH 2/2] misc: Add iop driver for Sunplus SP7021
> 
> On Wed, Nov 17, 2021 at 02:48:07PM +0800, Tony Huang wrote:
> > Add iop driver for Sunplus SP7021
> >
> > Signed-off-by: Tony Huang <tony.huang@...plus.com>
> 
> Along with everything that Arnd said, one more thing:
> 
> > +#define IOP_KDBG_INFO
> > +#define IOP_FUNC_DEBUG
> > +#define IOP_KDBG_ERR
> > +#ifdef IOP_KDBG_INFO
> > +	#define FUNC_DEBUG()	pr_info("K_IOP: %s(%d)\n", __func__, __LINE__)
> > +#else
> > +	#define FUNC_DEBUG()
> > +#endif
> 
> This should just be deleted entirely, use ftrace if you want to see what your
> kernel driver is doing.

OK, I will delete it.

> 
> No single driver should have special debugging macros like this, use the
> kernel-wide system please.
> 
> This driver code can get a lot smaller after you make these cleanups.
> Also be sure to use scripts/checkpatch.pl to remove the issues that it points out
> so we don't have to say the same thing.
> 
> thanks,
> 
> greg k-h