linux-kernel - Re: [PATCH 3/3] spi: spi-rspi: Drop redeclaring ret variable in qspi_transfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdWkeXUzgoPCzxTSv65EGLyQTi_R8WnqOLievLrW9K7kFQ@mail.gmail.com>
Date:   Wed, 17 Nov 2021 09:57:05 +0100
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Cc:     Mark Brown <broonie@...nel.org>, Rob Herring <robh+dt@...nel.org>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        linux-spi <linux-spi@...r.kernel.org>,
        Arnd Bergmann <arnd@...db.de>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Prabhakar <prabhakar.csengg@...il.com>,
        Biju Das <biju.das.jz@...renesas.com>
Subject: Re: [PATCH 3/3] spi: spi-rspi: Drop redeclaring ret variable in qspi_transfer_in()

On Wed, Nov 17, 2021 at 2:05 AM Lad Prabhakar
<prabhakar.mahadev-lad.rj@...renesas.com> wrote:
> "ret" variable is already declared in qspi_transfer_in() at the
> beginning of function, drop redeclaring ret in the if block, fixing
> below:
>
> spi-rspi.c: In function ‘qspi_transfer_in’:
> spi-rspi.c:838:7: warning: declaration of ‘ret’ shadows a previous local
>   838 |   int ret = rspi_dma_transfer(rspi, NULL, &xfer->rx_sg);
>       |       ^~~
> spi-rspi.c:835:6: note: shadowed declaration is here
>   835 |  int ret;
>
> Fixes: db30083813b55 ("spi: rspi: avoid uninitialized variable access")
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds