[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CA+V-a8sJoNJuKJ3Hcq8LkZsS7SazywuEOYR3KLPZH117qDk+Rg@mail.gmail.com>
Date: Wed, 17 Nov 2021 08:57:27 +0000
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>,
Mark Brown <broonie@...nel.org>,
Rob Herring <robh+dt@...nel.org>,
Philipp Zabel <p.zabel@...gutronix.de>,
linux-spi <linux-spi@...r.kernel.org>,
Arnd Bergmann <arnd@...db.de>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@...r.kernel.org>,
Linux-Renesas <linux-renesas-soc@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Biju Das <biju.das.jz@...renesas.com>
Subject: Re: [PATCH 1/3] dt-bindings: spi: renesas,rspi: Document RZ/G2L SoC
Hi Geert,
Thank you for the review.
On Wed, Nov 17, 2021 at 8:51 AM Geert Uytterhoeven <geert@...ux-m68k.org> wrote:
>
> Hi Prabhakar,
>
> On Wed, Nov 17, 2021 at 2:05 AM Lad Prabhakar
> <prabhakar.mahadev-lad.rj@...renesas.com> wrote:
> > Add RSPI binding documentation for Renesas RZ/G2L SoC.
> >
> > RSPI block is identical to one found on RZ/A, so no driver changes are
> > required the fallback compatible string "renesas,rspi-rz" will be used
>
> ... required. The ...
>
will fix that.
> > on RZ/G2L
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
> > Reviewed-by: Biju Das <biju.das.jz@...renesas.com>
>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
>
> > --- a/Documentation/devicetree/bindings/spi/renesas,rspi.yaml
> > +++ b/Documentation/devicetree/bindings/spi/renesas,rspi.yaml
> > @@ -21,7 +21,8 @@ properties:
> > - enum:
> > - renesas,rspi-r7s72100 # RZ/A1H
> > - renesas,rspi-r7s9210 # RZ/A2
> > - - const: renesas,rspi-rz # RZ/A
> > + - renesas,r9a07g044-rspi # RZ/G2{L,LC}
> > + - const: renesas,rspi-rz # RZ/A and RZ/G2{L,LC}
> >
> > - items:
> > - enum:
> > @@ -116,6 +117,16 @@ allOf:
> > required:
> > - interrupt-names
> >
> > + - if:
> > + properties:
> > + compatible:
> > + contains:
> > + enum:
> > + - renesas,r9a07g044-rspi
> > + then:
> > + required:
> > + - resets
> > +
>
> You may want to merge this with the existing section that makes
> resets required for renesas,qspi.
>
Right, I completely missed that.
Cheers,
Prabhakar
> > - if:
> > properties:
> > compatible:
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
Powered by blists - more mailing lists