linux-kernel - Re: [PATCH 5/9] arm64: Make __get_wchan() use arch_stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YZUkrrBwFJBiRhs9@sirena.org.uk>
Date:   Wed, 17 Nov 2021 15:50:06 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Mark Rutland <mark.rutland@....com>
Cc:     linux-arm-kernel@...ts.infradead.org, aou@...s.berkeley.edu,
        borntraeger@...ibm.com, bp@...en8.de, catalin.marinas@....com,
        dave.hansen@...ux.intel.com, gor@...ux.ibm.com, hca@...ux.ibm.com,
        linux-kernel@...r.kernel.org, madvenka@...ux.microsoft.com,
        mhiramat@...nel.org, mingo@...hat.com, mpe@...erman.id.au,
        palmer@...belt.com, paul.walmsley@...ive.com, peterz@...radead.org,
        rostedt@...dmis.org, tglx@...utronix.de, will@...nel.org
Subject: Re: [PATCH 5/9] arm64: Make __get_wchan() use arch_stack_walk()

On Wed, Nov 17, 2021 at 02:07:33PM +0000, Mark Rutland wrote:

> +static bool get_wchan_cb(void *arg, unsigned long pc)
> +{
> +	struct wchan_info *wchan_info = arg;
> +
> +	if (!in_sched_functions(pc)) {
> +		wchan_info->pc = pc;
> +		return false;
> +	}
> +	return wchan_info->count++ < 16;
> +}

I don't love the magic number but it was there before so not a problem
for this patch so

Reviewed-by: Mark Brown <broonie@...nel.org>

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)