linux-kernel - Re: [PATCH 2/9] arm64: Add comment for stack_info::kr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 19 Nov 2021 07:25:03 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Mark Rutland <mark.rutland@....com>
Cc:     linux-arm-kernel@...ts.infradead.org, aou@...s.berkeley.edu,
        borntraeger@...ibm.com, bp@...en8.de, broonie@...nel.org,
        catalin.marinas@....com, dave.hansen@...ux.intel.com,
        gor@...ux.ibm.com, hca@...ux.ibm.com, linux-kernel@...r.kernel.org,
        madvenka@...ux.microsoft.com, mhiramat@...nel.org,
        mingo@...hat.com, mpe@...erman.id.au, palmer@...belt.com,
        paul.walmsley@...ive.com, peterz@...radead.org,
        rostedt@...dmis.org, tglx@...utronix.de, will@...nel.org
Subject: Re: [PATCH 2/9] arm64: Add comment for stack_info::kr_cur

On Wed, 17 Nov 2021 14:07:30 +0000
Mark Rutland <mark.rutland@....com> wrote:

> We added stack_info::kr_cur in commit:
> 
>   cd9bc2c9258816dc ("arm64: Recover kretprobe modified return address in stacktrace")
> 
> ... but didn't add anything in the corresponding comment block.

Thanks for adding the comment!

Reviewed-by: Masami Hiramatsu <mhiramat@...nel.org>

Regards,
> 
> For consistency, add a corresponding comment.
> 
> Signed-off-by: Mark Rutland <mark.rutland@....com>
> Cc: Masami Hiramatsu <mhiramat@...nel.org>
> Cc: Steven Rostedt (VMware) <rostedt@...dmis.org>
> Cc: Will Deacon <will@...nel.org>
> ---
>  arch/arm64/include/asm/stacktrace.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/include/asm/stacktrace.h b/arch/arm64/include/asm/stacktrace.h
> index 6564a01cc085..686731b9df05 100644
> --- a/arch/arm64/include/asm/stacktrace.h
> +++ b/arch/arm64/include/asm/stacktrace.h
> @@ -47,6 +47,10 @@ struct stack_info {
>   * @prev_type:   The type of stack this frame record was on, or a synthetic
>   *               value of STACK_TYPE_UNKNOWN. This is used to detect a
>   *               transition from one stack to another.
> + *
> + * @kr_cur:      When KRETPOLINES is selected, holds the kretprobe instance
> + *               associated with the most recently encountered replacement lr
> + *               value.
>   */
>  struct stackframe {
>  	unsigned long fp;
> -- 
> 2.11.0
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>