linux-kernel - Re: [PATCH 2/9] arm64: Add comment for stack_info::kr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Tue, 23 Nov 2021 11:47:19 +0000
From:   Mark Rutland <mark.rutland@....com>
To:     linux-arm-kernel@...ts.infradead.org
Cc:     aou@...s.berkeley.edu, borntraeger@...ibm.com, bp@...en8.de,
        broonie@...nel.org, catalin.marinas@....com,
        dave.hansen@...ux.intel.com, gor@...ux.ibm.com, hca@...ux.ibm.com,
        linux-kernel@...r.kernel.org, madvenka@...ux.microsoft.com,
        mhiramat@...nel.org, mingo@...hat.com, mpe@...erman.id.au,
        palmer@...belt.com, paul.walmsley@...ive.com, peterz@...radead.org,
        rostedt@...dmis.org, tglx@...utronix.de, will@...nel.org
Subject: Re: [PATCH 2/9] arm64: Add comment for stack_info::kr_cur

On Wed, Nov 17, 2021 at 02:07:30PM +0000, Mark Rutland wrote:
> We added stack_info::kr_cur in commit:
> 
>   cd9bc2c9258816dc ("arm64: Recover kretprobe modified return address in stacktrace")
> 
> ... but didn't add anything in the corresponding comment block.
> 
> For consistency, add a corresponding comment.
> 
> Signed-off-by: Mark Rutland <mark.rutland@....com>
> Cc: Masami Hiramatsu <mhiramat@...nel.org>
> Cc: Steven Rostedt (VMware) <rostedt@...dmis.org>
> Cc: Will Deacon <will@...nel.org>
> ---
>  arch/arm64/include/asm/stacktrace.h | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/include/asm/stacktrace.h b/arch/arm64/include/asm/stacktrace.h
> index 6564a01cc085..686731b9df05 100644
> --- a/arch/arm64/include/asm/stacktrace.h
> +++ b/arch/arm64/include/asm/stacktrace.h
> @@ -47,6 +47,10 @@ struct stack_info {
>   * @prev_type:   The type of stack this frame record was on, or a synthetic
>   *               value of STACK_TYPE_UNKNOWN. This is used to detect a
>   *               transition from one stack to another.
> + *
> + * @kr_cur:      When KRETPOLINES is selected, holds the kretprobe instance

As peter pointed out on IRC, this should be KRETPROBES, not KRETPOLINES
(which does not exist as a Kconfig symbol).

I'll fix that for v2.

Mark.

> + *               associated with the most recently encountered replacement lr
> + *               value.
>   */
>  struct stackframe {
>  	unsigned long fp;
> -- 
> 2.11.0
>