linux-kernel - Re: [PATCH v10 0/5] Add Xilinx AMS Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 17 Nov 2021 19:13:54 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Anand Ashok Dumbre <anand.ashok.dumbre@...inx.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        linux-iio <linux-iio@...r.kernel.org>, git <git@...inx.com>,
        Michal Simek <michal.simek@...inx.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J. Wysocki" <rafael@...nel.org>,
        ACPI Devel Maling List <linux-acpi@...r.kernel.org>,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        "Krogerus, Heikki" <heikki.krogerus@...ux.intel.com>
Subject: Re: [PATCH v10 0/5] Add Xilinx AMS Driver

On Wed, Nov 17, 2021 at 6:46 PM Anand Ashok Dumbre
<anand.ashok.dumbre@...inx.com> wrote:
>
> Add Xilinx AMS driver which is used for Xilinx's ZynqMP AMS controller.
> This AMS driver is used to report various interface voltages and temperatures
> across the system.
> This driver will be used by iio-hwmon to repport voltages and temperatures
> across the system by using various channel interfaces.
> This driver handles AMS module including PS-Sysmon & PL-Sysmon. The binding
> documentation is added for understanding of AMS, PS, PL Sysmon Channels.

Thanks and wait a bit, please. No need to send patches so often. We
haven't settled down yet on v9. Here you effectively ignored my
comment given again patch 5/5. Why?

...

> Changes in v10:
>         - Fixed licence in zynqmp.dtsi.
>         - Changed the macros to use BIT().
>         - Realign some code to fit within 100 chars.
>         - Modified readl_poll_timeout usage.

>         - Usage of array_size() instead of check_mul_overflow().

Why? I have asked you why you haven't used kcalloc there as well.

>         - Usage of dev_err_probe() instead of dev_err().
>         - Usage of kcalloc instead of kzalloc()

-- 
With Best Regards,
Andy Shevchenko