linux-kernel - Re: [PATCH v10 3/5] iio: adc: Add Xilinx AMS driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 18 Nov 2021 03:01:04 +0800
From:   kernel test robot <lkp@...el.com>
To:     Anand Ashok Dumbre <anand.ashok.dumbre@...inx.com>,
        linux-kernel@...r.kernel.org, jic23@...nel.org, lars@...afoo.de,
        linux-iio@...r.kernel.org, git@...inx.com, michal.simek@...inx.com,
        gregkh@...uxfoundation.org, rafael@...nel.org,
        linux-acpi@...r.kernel.org, andriy.shevchenko@...ux.intel.com
Cc:     kbuild-all@...ts.01.org
Subject: Re: [PATCH v10 3/5] iio: adc: Add Xilinx AMS driver

Hi Anand,

Thank you for the patch! Perhaps something to improve:

[auto build test WARNING on jic23-iio/togreg]
[also build test WARNING on linux/master linus/master v5.16-rc1 next-20211117]
[cannot apply to xilinx-xlnx/master]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Anand-Ashok-Dumbre/Add-Xilinx-AMS-Driver/20211118-001150
base:   https://git.kernel.org/pub/scm/linux/kernel/git/jic23/iio.git togreg
config: sparc64-randconfig-s032-20211118 (attached as .config)
compiler: sparc64-linux-gcc (GCC) 11.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.4-dirty
        # https://github.com/0day-ci/linux/commit/196a4a5b4232a4a12d0843a0002b664720b5d200
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Anand-Ashok-Dumbre/Add-Xilinx-AMS-Driver/20211118-001150
        git checkout 196a4a5b4232a4a12d0843a0002b664720b5d200
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=sparc64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   drivers/iio/adc/xilinx-ams.c: In function 'ams_update_intrmask':
   drivers/iio/adc/xilinx-ams.c:323:20: error: implicit declaration of function 'FIELD_GET' [-Werror=implicit-function-declaration]
     323 |         regval = ~(FIELD_GET(AMS_ISR1_INTR_MASK, ams->intr_mask));
         |                    ^~~~~~~~~
   drivers/iio/adc/xilinx-ams.c: In function 'ams_update_ps_alarm':
   drivers/iio/adc/xilinx-ams.c:360:17: error: implicit declaration of function 'FIELD_PREP' [-Werror=implicit-function-declaration]
     360 |         cfg = ~(FIELD_PREP(AMS_CONF1_ALARM_2_TO_0_MASK, val));
         |                 ^~~~~~~~~~
   drivers/iio/adc/xilinx-ams.c: In function 'ams_parse_firmware':
>> drivers/iio/adc/xilinx-ams.c:121:41: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709486080' to '4294901760' [-Woverflow]
     121 | #define AMS_ALARM_THR_MIN               ~(BIT(16) - 1)
         |                                         ^~~~~~~~~~~~~~
   drivers/iio/adc/xilinx-ams.c:1285:40: note: in expansion of macro 'AMS_ALARM_THR_MIN'
    1285 |                                 writel(AMS_ALARM_THR_MIN,
         |                                        ^~~~~~~~~~~~~~~~~
>> drivers/iio/adc/xilinx-ams.c:121:41: warning: conversion from 'long unsigned int' to 'u32' {aka 'unsigned int'} changes value from '18446744073709486080' to '4294901760' [-Woverflow]
     121 | #define AMS_ALARM_THR_MIN               ~(BIT(16) - 1)
         |                                         ^~~~~~~~~~~~~~
   drivers/iio/adc/xilinx-ams.c:1290:40: note: in expansion of macro 'AMS_ALARM_THR_MIN'
    1290 |                                 writel(AMS_ALARM_THR_MIN,
         |                                        ^~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors


vim +121 drivers/iio/adc/xilinx-ams.c

   119	
   120	#define AMS_ALARM_THR_DIRECT_MASK	BIT(1)
 > 121	#define AMS_ALARM_THR_MIN		~(BIT(16) - 1)
   122	#define AMS_ALARM_THR_MAX		(BIT(16) - 1)
   123	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Download attachment ".config.gz" of type "application/gzip" (43402 bytes)