linux-kernel - Re: [PATCH stable 4.9] net: mdio-mux: fix unbalanced put

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YZVH0u5bTOXhQw56@kroah.com>
Date:   Wed, 17 Nov 2021 19:20:02 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     stable@...r.kernel.org, Corentin Labbe <clabbe.montjoie@...il.com>,
        Andrew Lunn <andrew@...n.ch>,
        "David S . Miller" <davem@...emloft.net>,
        "open list:ETHERNET PHY LIBRARY" <netdev@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH stable 4.9] net: mdio-mux: fix unbalanced put_device

On Wed, Nov 17, 2021 at 10:03:08AM -0800, Florian Fainelli wrote:
> From: Corentin Labbe <clabbe.montjoie@...il.com>
> 
> commit 60f786525032432af1b7d9b8935cb12936244ccd upstream
> 
> mdio_mux_uninit() call put_device (unconditionally) because of
> of_mdio_find_bus() in mdio_mux_init.
> But of_mdio_find_bus is only called if mux_bus is empty.
> If mux_bus is set, mdio_mux_uninit will print a "refcount_t: underflow"
> trace.
> 
> This patch add a get_device in the other branch of "if (mux_bus)".
> 
> Signed-off-by: Corentin Labbe <clabbe.montjoie@...il.com>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Signed-off-by: David S. Miller <davem@...emloft.net>
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>
> ---
> Note: this patch did not get any fixes tag, but it does fix issues
> introduced by  fdf3b78df4d2 ("mdio: mux: Correct mdio_mux_init error
> path issues").

Now queued up, thanks.

greg k-h