linux-kernel - Re: [PATCH 0/2] usb: typec: tipd: Fixes for Apple M1 (CD321X) support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <7bac877d-1929-4caf-be8d-8405c5cfd3ba@www.fastmail.com>
Date:   Wed, 17 Nov 2021 19:19:49 +0100
From:   "Sven Peter" <sven@...npeter.dev>
To:     "Hector Martin" <marcan@...can.st>,
        "Heikki Krogerus" <heikki.krogerus@...ux.intel.com>,
        "Greg Kroah-Hartman" <gregkh@...uxfoundation.org>
Cc:     Guido Günther <agx@...xcpu.org>,
        "Alyssa Rosenzweig" <alyssa@...enzweig.io>,
        linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] usb: typec: tipd: Fixes for Apple M1 (CD321X) support

On Wed, Nov 17, 2021, at 16:14, Hector Martin wrote:
> Hi folks,
>
> These two fixes make tipd work properly on Apple M1 devices, in
> particular in the case where the bootloader hasn't initialized
> the controllers yet.
>
> We normally do it in m1n1 (so the machine can charge and so bootloaders
> get working USB without needing this driver), but that was causing this
> codepath to never get properly exercised, so we never caught it. I

My boot process usually is iBoot -> m1n1 on nvme -> m1n1 chainloaded over usb.
I thought I exercised this path by turning off the init in m1n1. I didn't take
into account that this would only affect the one loaded over usb and that
the one on nvme would still intitialize everything.
Thanks for fixing this!

With the Fixes tags feel free to add

Reviewed-by: Sven Peter <sven@...npeter.dev>

to both patches.

Sven