linux-kernel - Re: [PATCH] mm/page_counter: remove an incorrect call to propagate_protected

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YZamdpfPfw26i8sd@carbon.dhcp.thefacebook.com>
Date:   Thu, 18 Nov 2021 11:16:06 -0800
From:   Roman Gushchin <guro@...com>
To:     Donghai Qiao <dqiao@...hat.com>
CC:     <akpm@...ux-foundation.org>, <linux-mm@...ck.org>,
        <linux-kernel@...r.kernel.org>, <mhocko@...nel.org>,
        <hannes@...xchg.org>
Subject: Re: [PATCH] mm/page_counter: remove an incorrect call to
 propagate_protected_usage()

On Thu, Nov 18, 2021 at 01:11:25PM -0500, Donghai Qiao wrote:
> The function propagate_protected_usage() is called to propagate the usage
> change in the page_counter structure. But there is call to this function
> from page_counter_try_charge() when there is actually no usage change.
> Hence this call should be removed.
> 
> Signed-off-by: Donghai Qiao <dqiao@...hat.com>

Reviewed-by: Roman Gushchin <guro@...com>

Thanks, Donghai!