linux-kernel - Re: [PATCH] bus: mhi: core: Read missing channel configuration entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20211118060720.GC6461@thinkpad>
Date:   Thu, 18 Nov 2021 11:37:20 +0530
From:   Manivannan Sadhasivam <mani@...nel.org>
To:     Bhaumik Bhatt <quic_bbhatt@...cinc.com>
Cc:     manivannan.sadhasivam@...aro.org, linux-arm-msm@...r.kernel.org,
        quic_hemantk@...cinc.com, linux-kernel@...r.kernel.org,
        loic.poulain@...aro.org
Subject: Re: [PATCH] bus: mhi: core: Read missing channel configuration entry

On Thu, Nov 04, 2021 at 05:31:13PM -0700, Bhaumik Bhatt wrote:
> The 'wake-capable' entry in channel configuration is not set when
> parsing the configuration specified by the controller driver. Add
> the missing entry to ensure channel is correctly specified as a
> 'wake-capable' channel.
> 
> Signed-off-by: Bhaumik Bhatt <quic_bbhatt@...cinc.com>

Reviewed-by: Manivannan Sadhasivam <mani@...nel.org>

Looks like this one is qualified as a bug fix. Please add the fixes tag and Cc
stable.

And the subject could be,
"bus: mhi: core: Fix reading wake_capable configuration"

Thanks,
Mani

> ---
>  drivers/bus/mhi/core/init.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/bus/mhi/core/init.c b/drivers/bus/mhi/core/init.c
> index 5aaca6d..f1ec3441 100644
> --- a/drivers/bus/mhi/core/init.c
> +++ b/drivers/bus/mhi/core/init.c
> @@ -788,6 +788,7 @@ static int parse_ch_cfg(struct mhi_controller *mhi_cntrl,
>  		mhi_chan->offload_ch = ch_cfg->offload_channel;
>  		mhi_chan->db_cfg.reset_req = ch_cfg->doorbell_mode_switch;
>  		mhi_chan->pre_alloc = ch_cfg->auto_queue;
> +		mhi_chan->wake_capable = ch_cfg->wake_capable;
>  
>  		/*
>  		 * If MHI host allocates buffers, then the channel direction
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>