linux-kernel - Re: [PATCH v1 1/3] media: staging: tegra-vde: Support reference picture marking

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211118060735.GN26989@kadam>
Date:   Thu, 18 Nov 2021 09:07:35 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Dmitry Osipenko <digetx@...il.com>
Cc:     Thierry Reding <thierry.reding@...il.com>,
        Jonathan Hunter <jonathanh@...dia.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Anton Bambura <jenneron@...tonmail.com>,
        Hans Verkuil <hverkuil@...all.nl>, linux-media@...r.kernel.org,
        linux-staging@...ts.linux.dev, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1 1/3] media: staging: tegra-vde: Support reference
 picture marking

On Wed, Nov 17, 2021 at 07:19:30PM +0300, Dmitry Osipenko wrote:
> 15.11.2021 18:48, Dan Carpenter пишет:
> > On Mon, Nov 15, 2021 at 05:34:47PM +0300, Dmitry Osipenko wrote:
> >> 15.11.2021 15:44, Dan Carpenter пишет:
> >>> On Mon, Nov 15, 2021 at 01:34:18AM +0300, Dmitry Osipenko wrote:
> >>>> 15.11.2021 01:23, Dmitry Osipenko пишет:
> >>>>> +	vde->secure_bo = tegra_vde_alloc_bo(vde, DMA_FROM_DEVICE, 4096);
> >>>>> +	if (!vde->secure_bo) {
> >>>>> +		dev_err(dev, "Failed to allocate secure BO\n");
> >>>>> +		goto err_pm_runtime;
> >>>>> +	}
> >>>>
> >>>> My eye just caught that by accident err variable isn't assigned to
> >>>> -ENOMEM here. I'll make v2 shortly.
> >>>
> >>> Smatch has a check for this so we would have caught it.  :)
> >>
> >> Whish smatch was built-in into kernel and I could simply run "make
> >> smatch". On the other hand, I know that you're periodically checking
> >> upstream with smatch and patching the found bugs, so maybe it's fine
> >> as-is.
> > 
> > I run it every day, and it's integrated into the zero day bot and Mauro
> > runs it.  So someone would have caught it.
> 
> Very nice, I haven't noticed that 0-day runs smatch. I assume the smatch
> reports from the bots are private to you and Mauro since I never saw
> them in my inbox and on LKML, correct?

The 0-day bot is not great about running Smatch honestly...  It never
ran Smatch on this.  It would have replied to the thread.

regards,
dan carpenter