linux-kernel - Re: [PATCH RESEND] staging: vchiq_core: remove superfluous static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 22 Nov 2021 12:00:31 -0300
From:   Gaston Gonzalez <gascoar@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     linux-staging@...ts.linux.dev, gregkh@...uxfoundation.org,
        nsaenz@...nel.org, stefan.wahren@...e.com, arnd@...db.de,
        ojaswin98@...il.com, amarjargal16@...il.com,
        linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        bcm-kernel-feedback-list@...adcom.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] staging: vchiq_core: remove superfluous
 static_assert statement

On Mon, Nov 22, 2021 at 04:50:31PM +0300, Dan Carpenter wrote:
> On Mon, Nov 22, 2021 at 10:09:26AM -0300, Gaston Gonzalez wrote:
> > After removing the BITSET_T typedef in commit d8a364820e01 ("staging:
> > vchiq_core: get rid of typedef") the static_assert statement becomes superfluous
> > as now we are checking if the size of the u32 type is 4 bytes. Hence, just
> > remove the static_assert statement.
> > 
> > Suggested-by: Dan Carpenter <dan.carpenter@...cle.com>
> > Signed-off-by: Gaston Gonzalez <gascoar@...il.com>
> > ---
> 
> You sent the first version after the merge window had just started.
> It's too early to be resending stuff.  Leave it for two weeks after the
> end of the merge window at least.
> 
> regards,
> dan carpenter
>

Ah, ok. I thought it was ok to resend after one week once the merge
window was closed.

Sorry for the noise.

Gaston