linux-kernel - Re: [PATCH 01/11] ASoC: cs35l41: Set the max SPI speed for the whole device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211123180253.GF18506@ediswmail.ad.cirrus.com>
Date:   Tue, 23 Nov 2021 18:02:53 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Lucas Tanure <tanureal@...nsource.cirrus.com>
CC:     "Rafael J . Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <markgross@...nel.org>,
        "Liam Girdwood" <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Mark Brown <broonie@...nel.org>, Takashi Iwai <tiwai@...e.com>,
        Kailang Yang <kailang@...ltek.com>,
        Shuming Fan <shumingf@...ltek.com>,
        "Pierre-Louis Bossart" <pierre-louis.bossart@...ux.intel.com>,
        David Rhodes <david.rhodes@...rus.com>,
        Vitaly Rodionov <vitalyr@...nsource.cirrus.com>,
        Jeremy Szu <jeremy.szu@...onical.com>,
        Hui Wang <hui.wang@...onical.com>,
        Werner Sembach <wse@...edocomputers.com>,
        Chris Chiu <chris.chiu@...onical.com>,
        Cameron Berkenpas <cam@...-zeon.de>,
        Sami Loone <sami@...ne.fi>, Elia Devito <eliadevito@...il.com>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Jack Yu <jack.yu@...ltek.com>, "Arnd Bergmann" <arnd@...db.de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        "Alexandre Belloni" <alexandre.belloni@...tlin.com>,
        <alsa-devel@...a-project.org>, <linux-acpi@...r.kernel.org>,
        <patches@...nsource.cirrus.com>,
        <platform-driver-x86@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 01/11] ASoC: cs35l41: Set the max SPI speed for the whole
 device

On Tue, Nov 23, 2021 at 04:31:39PM +0000, Lucas Tanure wrote:
> Higher speeds are only supported when PLL is enabled, but
> the current driver doesn't enable PLL outside of stream
> use cases, so better to set the lowest SPI speed accepted
> by the entire device.
> 
> Move the current frequency set to the spi sub-driver so
> the whole device can benefit from that speed.
> 
> spi-max-frequency property could be used, but ACPI systems don't
> support it, so by setting it in the spi sub-driver probe
> both Device Trees and ACPI systems are supported.
> 
> Signed-off-by: Lucas Tanure <tanureal@...nsource.cirrus.com>
> ---

Reviewed-by: Charles Keepax <ckeepax@...nsource.cirrus.com>

Thanks,
Charles