linux-kernel - Re: [PATCH 02/11] ASoC: cs35l41: Convert tables to shared source code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 23 Nov 2021 18:05:54 +0000
From:   Charles Keepax <ckeepax@...nsource.cirrus.com>
To:     Mark Brown <broonie@...nel.org>
CC:     Lucas Tanure <tanureal@...nsource.cirrus.com>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Len Brown <lenb@...nel.org>,
        Hans de Goede <hdegoede@...hat.com>,
        Mark Gross <markgross@...nel.org>,
        Liam Girdwood <lgirdwood@...il.com>,
        Jaroslav Kysela <perex@...ex.cz>,
        Takashi Iwai <tiwai@...e.com>,
        Kailang Yang <kailang@...ltek.com>,
        Shuming Fan <shumingf@...ltek.com>,
        Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>,
        David Rhodes <david.rhodes@...rus.com>,
        Vitaly Rodionov <vitalyr@...nsource.cirrus.com>,
        Jeremy Szu <jeremy.szu@...onical.com>,
        Hui Wang <hui.wang@...onical.com>,
        Werner Sembach <wse@...edocomputers.com>,
        Chris Chiu <chris.chiu@...onical.com>,
        Cameron Berkenpas <cam@...-zeon.de>,
        Sami Loone <sami@...ne.fi>, Elia Devito <eliadevito@...il.com>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Jack Yu <jack.yu@...ltek.com>, "Arnd Bergmann" <arnd@...db.de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        "Alexandre Belloni" <alexandre.belloni@...tlin.com>,
        <alsa-devel@...a-project.org>, <linux-acpi@...r.kernel.org>,
        <patches@...nsource.cirrus.com>,
        <platform-driver-x86@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 02/11] ASoC: cs35l41: Convert tables to shared source code

On Tue, Nov 23, 2021 at 05:53:06PM +0000, Mark Brown wrote:
> On Tue, Nov 23, 2021 at 04:31:40PM +0000, Lucas Tanure wrote:
> > --- a/sound/soc/codecs/Makefile
> > +++ b/sound/soc/codecs/Makefile
> > @@ -54,8 +54,8 @@ snd-soc-cs35l33-objs := cs35l33.o
> >  snd-soc-cs35l34-objs := cs35l34.o
> >  snd-soc-cs35l35-objs := cs35l35.o
> >  snd-soc-cs35l36-objs := cs35l36.o
> > -snd-soc-cs35l41-spi-objs := cs35l41-spi.o cs35l41.o cs35l41-tables.o
> > -snd-soc-cs35l41-i2c-objs := cs35l41-i2c.o cs35l41.o cs35l41-tables.o
> > +snd-soc-cs35l41-spi-objs := cs35l41-spi.o cs35l41.o cs35l41-lib.o
> > +snd-soc-cs35l41-i2c-objs := cs35l41-i2c.o cs35l41.o cs35l41-lib.o
> >  snd-soc-cs42l42-objs := cs42l42.o
> >  snd-soc-cs42l51-objs := cs42l51.o
> >  snd-soc-cs42l51-i2c-objs := cs42l51-i2c.o
> 
> As was already called out on the HDA part of this patch I was expecting
> this to be more like how we handle sharing the PXA2xx driver code
> between the ASoC and AC'97 implementations - making it a library rather
> than linking the object files directly into both drivers.  I'm not sure
> that the current approach would DTRT if one or both of the drivers is
> built in.

Yeah looking closer the Prince driver itself is kinda weird here
since it is building separate modules for SPI and I2C but
including cs25l41.o into both, rather than the more normal 3
modules approach.

I will have a look at doing a patch to fix that up, separately
from Lucas's series here.

Thanks,
Charles