linux-kernel - Re: [PATCH 9/9] iommu: Move flush queue data into iommu_dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9dece0b8-2832-f467-91f3-f63ef0f70d16@huawei.com>
Date:   Wed, 24 Nov 2021 17:25:22 +0000
From:   John Garry <john.garry@...wei.com>
To:     Robin Murphy <robin.murphy@....com>, <joro@...tes.org>,
        <will@...nel.org>
CC:     <iommu@...ts.linux-foundation.org>,
        <suravee.suthikulpanit@....com>, <baolu.lu@...ux.intel.com>,
        <willy@...radead.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 9/9] iommu: Move flush queue data into iommu_dma_cookie

On 23/11/2021 14:10, Robin Murphy wrote:
> ruct iommu_dma_msi_page {
>   	struct list_head	list;
> @@ -41,7 +43,19 @@ struct iommu_dma_cookie {
>   	enum iommu_dma_cookie_type	type;
>   	union {
>   		/* Full allocator for IOMMU_DMA_IOVA_COOKIE */
> -		struct iova_domain	iovad;
> +		struct {
> +			struct iova_domain	iovad;
> +
> +			struct iova_fq __percpu *fq;	/* Flush queue */
> +			/* Number of TLB flushes that have been started */
> +			atomic64_t		fq_flush_start_cnt;
> +			/* Number of TLB flushes that have been finished */
> +			atomic64_t		fq_flush_finish_cnt;
> +			/* Timer to regularily empty the flush queues */
> +			struct timer_list	fq_timer;
> +			/* 1 when timer is active, 0 when not */
> +			atomic_t		fq_timer_on;

I thought that putting all the FQ stuff in its own structure would be 
neater, but that's just personal preference.

Thanks,
John