linux-kernel - Re: [PATCH] tracing/uprobe: Fix uprobe_perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20211124104526.a9da7deb3fe64c76f0bd9a86@kernel.org>
Date:   Wed, 24 Nov 2021 10:45:26 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Jiri Olsa <jolsa@...hat.com>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        lkml <linux-kernel@...r.kernel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Arnaldo Carvalho de Melo <acme@...nel.org>,
        Ravi Bangoria <ravi.bangoria@....com>,
        Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH] tracing/uprobe: Fix uprobe_perf_open probes iteration

On Tue, 23 Nov 2021 15:28:01 +0100
Jiri Olsa <jolsa@...hat.com> wrote:

> Add missing 'tu' variable initialization in the probes loop,
> otherwise the head 'tu' is used instead of added probes.

Thanks for fixing this bug!

Acked-by: Masami Hiramatsu <mhiramat@...nel.org>

> 
> Fixes: 99c9a923e97a ("tracing/uprobe: Fix double perf_event linking on multiprobe uprobe")
> Signed-off-by: Jiri Olsa <jolsa@...nel.org>
> ---
>  kernel/trace/trace_uprobe.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c
> index 0a5c0db3137e..f5f0039d31e5 100644
> --- a/kernel/trace/trace_uprobe.c
> +++ b/kernel/trace/trace_uprobe.c
> @@ -1313,6 +1313,7 @@ static int uprobe_perf_open(struct trace_event_call *call,
>  		return 0;
>  
>  	list_for_each_entry(pos, trace_probe_probe_list(tp), list) {
> +		tu = container_of(pos, struct trace_uprobe, tp);
>  		err = uprobe_apply(tu->inode, tu->offset, &tu->consumer, true);
>  		if (err) {
>  			uprobe_perf_close(call, event);
> -- 
> 2.32.0
> 


-- 
Masami Hiramatsu <mhiramat@...nel.org>