linux-kernel - Re: [PATCH V7 05/14] rtla/osnoise: Add the hist mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 25 Nov 2021 14:45:30 +0100
From:   Daniel Bristot de Oliveira <bristot@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Tao Zhou <tao.zhou@...ux.dev>, Ingo Molnar <mingo@...hat.com>,
        Tom Zanussi <zanussi@...nel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Clark Williams <williams@...hat.com>,
        John Kacur <jkacur@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        linux-rt-users@...r.kernel.org, linux-trace-devel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V7 05/14] rtla/osnoise: Add the hist mode

On 11/24/21 23:15, Steven Rostedt wrote:
>>> +	/*
>>> +	 * Set the size of the bucket.
>>> +	 */
>>> +	bucket_size = params->output_divisor * params->bucket_size;
>>> +	snprintf(buff, sizeof(buff), "duration.buckets=%d", bucket_size);
>>> +
>>> +	data->trace_hist = tracefs_hist_alloc(tool->trace.tep, "osnoise", "sample_threshold",
>>> +			buff, TRACEFS_HIST_KEY_NORMAL);  
>> FYI, we changed the API (haven't tagged it yet, so we can do that :-) and
>> the above needs to be:
>>
>> 	data->trace_hist = tracefs_hist1d_alloc(tool->trace.tep, "osnoise", "sample_threshold",
> Or do you think that 1d should be the default, and we have:
> 
> 	tracefs_hist_alloc()	-- 1d histogram
> 	tracefs_hist_alloc_2d()	-- 2d histogram
> 	tracefs_hist_alloc_nd()	-- Nd histogram?
> 
> ??

IMHO, the function names in your second email sound more intuitive, i.e.,
tracefs_hist_alloc()/tracefs_hist_alloc_2d()/tracefs_hist_alloc_nd().

> We haven't tagged it yet, so we could change it again (and then your code
> will work as is).

two birds with a single stone :-)

-- Daniel
> -- Steve