linux-kernel - Re: [PATCH V7 05/14] rtla/osnoise: Add the hist mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <65848fd0-0b37-dde6-fa5a-259c07b69f34@kernel.org>
Date:   Thu, 25 Nov 2021 15:30:19 +0100
From:   Daniel Bristot de Oliveira <bristot@...nel.org>
To:     Steven Rostedt <rostedt@...dmis.org>
Cc:     Tao Zhou <tao.zhou@...ux.dev>, Ingo Molnar <mingo@...hat.com>,
        Tom Zanussi <zanussi@...nel.org>,
        Masami Hiramatsu <mhiramat@...nel.org>,
        Juri Lelli <juri.lelli@...hat.com>,
        Clark Williams <williams@...hat.com>,
        John Kacur <jkacur@...hat.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        linux-rt-users@...r.kernel.org, linux-trace-devel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V7 05/14] rtla/osnoise: Add the hist mode

On 11/25/21 15:20, Steven Rostedt wrote:
> On Thu, 25 Nov 2021 14:45:30 +0100
> Daniel Bristot de Oliveira <bristot@...nel.org> wrote:
> 
>>> Or do you think that 1d should be the default, and we have:
>>>
>>> 	tracefs_hist_alloc()	-- 1d histogram
>>> 	tracefs_hist_alloc_2d()	-- 2d histogram
>>> 	tracefs_hist_alloc_nd()	-- Nd histogram?
>>>
>>> ??  
>>
>> IMHO, the function names in your second email sound more intuitive, i.e.,
>> tracefs_hist_alloc()/tracefs_hist_alloc_2d()/tracefs_hist_alloc_nd().
>>
>>> We haven't tagged it yet, so we could change it again (and then your code
>>> will work as is).  
>>
>> two birds with a single stone :-)
> 
> Just to confirm (confused by "second email" above), you prefer that we
> update the API to:
> 
> 	tracefs_hist_alloc()
> 	tracefs_hist_alloc_2d()
> 	tracefs_hist_alloc_nd()
> 
> Right?

Right!

-- Daniel

> Thanks,
> 
> -- Steve
>