linux-kernel - Re: [PATCH net-next 4/4] net: mvneta: Add TC traffic shaping offload

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20211125095029.342b3594@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com>
Date:   Thu, 25 Nov 2021 09:50:29 -0800
From:   Jakub Kicinski <kuba@...nel.org>
To:     Maxime Chevallier <maxime.chevallier@...tlin.com>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, thomas.petazzoni@...tlin.com,
        gregory.clement@...tlin.com, Andrew Lunn <andrew@...n.ch>,
        Pali Rohár <pali@...nel.org>
Subject: Re: [PATCH net-next 4/4] net: mvneta: Add TC traffic shaping
 offload

On Thu, 25 Nov 2021 16:48:13 +0100 Maxime Chevallier wrote:
> The mvneta controller is able to do some tocken-bucket per-queue traffic
> shaping. This commit adds support for setting these using the TC mqprio
> interface.
> 
> The token-bucket parameters are customisable, but the current
> implementation configures them to have a 10kbps resolution for the
> rate limitation, since it allows to cover the whole range of max_rate
> values from 10kbps to 5Gbps with 10kbps increments.
> 
> Signed-off-by: Maxime Chevallier <maxime.chevallier@...tlin.com>

Breaks 32bit build, please make sure you use division helpers for 64b.