| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202111270145.6iqJ5sdb-lkp@intel.com>
Date: Sat, 27 Nov 2021 01:41:05 +0800
From: kernel test robot <lkp@...el.com>
To: Dave Ertman <david.m.ertman@...el.com>
Cc: llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
linux-kernel@...r.kernel.org,
Tony Nguyen <anthony.l.nguyen@...el.com>,
Anirudh Venkataramanan <anirudh.venkataramanan@...el.com>
Subject: drivers/net/ethernet/intel/ice/ice_dcb_nl.c:66:6: warning: variable
'bwcfg' set but not used
Hi Dave,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: a4849f6000e29235a2707f22e39da6b897bb9543
commit: 2a87bd73e50d1c71392c036b0b31c9b2418981d0 ice: Add DSCP support
date: 8 weeks ago
config: i386-randconfig-a003-20211126 (https://download.01.org/0day-ci/archive/20211127/202111270145.6iqJ5sdb-lkp@intel.com/config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project 5162b558d8c0b542e752b037e72a69d5fd51eb1e)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=2a87bd73e50d1c71392c036b0b31c9b2418981d0
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 2a87bd73e50d1c71392c036b0b31c9b2418981d0
# save the config file to linux build tree
mkdir build_dir
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/net/ethernet/intel/ice/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
>> drivers/net/ethernet/intel/ice/ice_dcb_nl.c:66:6: warning: variable 'bwcfg' set but not used [-Wunused-but-set-variable]
int bwcfg = 0, bwrec = 0;
^
1 warning generated.
vim +/bwcfg +66 drivers/net/ethernet/intel/ice/ice_dcb_nl.c
b94b013eb626952 Dave Ertman 2019-11-06 56
b94b013eb626952 Dave Ertman 2019-11-06 57 /**
b94b013eb626952 Dave Ertman 2019-11-06 58 * ice_dcbnl_setets - set IEEE ETS configuration
b94b013eb626952 Dave Ertman 2019-11-06 59 * @netdev: pointer to relevant netdev
b94b013eb626952 Dave Ertman 2019-11-06 60 * @ets: struct to hold ETS configuration
b94b013eb626952 Dave Ertman 2019-11-06 61 */
b94b013eb626952 Dave Ertman 2019-11-06 62 static int ice_dcbnl_setets(struct net_device *netdev, struct ieee_ets *ets)
b94b013eb626952 Dave Ertman 2019-11-06 63 {
b94b013eb626952 Dave Ertman 2019-11-06 64 struct ice_pf *pf = ice_netdev_to_pf(netdev);
b94b013eb626952 Dave Ertman 2019-11-06 65 struct ice_dcbx_cfg *new_cfg;
b94b013eb626952 Dave Ertman 2019-11-06 @66 int bwcfg = 0, bwrec = 0;
2a87bd73e50d1c7 Dave Ertman 2021-08-06 67 int err, i;
b94b013eb626952 Dave Ertman 2019-11-06 68
b94b013eb626952 Dave Ertman 2019-11-06 69 if ((pf->dcbx_cap & DCB_CAP_DCBX_LLD_MANAGED) ||
b94b013eb626952 Dave Ertman 2019-11-06 70 !(pf->dcbx_cap & DCB_CAP_DCBX_VER_IEEE))
b94b013eb626952 Dave Ertman 2019-11-06 71 return -EINVAL;
b94b013eb626952 Dave Ertman 2019-11-06 72
fc2d1165d4a424d Chinh T Cao 2020-11-20 73 new_cfg = &pf->hw.port_info->qos_cfg.desired_dcbx_cfg;
b94b013eb626952 Dave Ertman 2019-11-06 74
b94b013eb626952 Dave Ertman 2019-11-06 75 mutex_lock(&pf->tc_mutex);
b94b013eb626952 Dave Ertman 2019-11-06 76
b94b013eb626952 Dave Ertman 2019-11-06 77 new_cfg->etscfg.willing = ets->willing;
b94b013eb626952 Dave Ertman 2019-11-06 78 new_cfg->etscfg.cbs = ets->cbs;
b94b013eb626952 Dave Ertman 2019-11-06 79 ice_for_each_traffic_class(i) {
b94b013eb626952 Dave Ertman 2019-11-06 80 new_cfg->etscfg.tcbwtable[i] = ets->tc_tx_bw[i];
b94b013eb626952 Dave Ertman 2019-11-06 81 bwcfg += ets->tc_tx_bw[i];
b94b013eb626952 Dave Ertman 2019-11-06 82 new_cfg->etscfg.tsatable[i] = ets->tc_tsa[i];
2a87bd73e50d1c7 Dave Ertman 2021-08-06 83 if (new_cfg->pfc_mode == ICE_QOS_MODE_VLAN) {
2a87bd73e50d1c7 Dave Ertman 2021-08-06 84 /* in DSCP mode up->tc mapping cannot change */
b94b013eb626952 Dave Ertman 2019-11-06 85 new_cfg->etscfg.prio_table[i] = ets->prio_tc[i];
2a87bd73e50d1c7 Dave Ertman 2021-08-06 86 new_cfg->etsrec.prio_table[i] = ets->reco_prio_tc[i];
2a87bd73e50d1c7 Dave Ertman 2021-08-06 87 }
b94b013eb626952 Dave Ertman 2019-11-06 88 new_cfg->etsrec.tcbwtable[i] = ets->tc_reco_bw[i];
b94b013eb626952 Dave Ertman 2019-11-06 89 bwrec += ets->tc_reco_bw[i];
b94b013eb626952 Dave Ertman 2019-11-06 90 new_cfg->etsrec.tsatable[i] = ets->tc_reco_tsa[i];
b94b013eb626952 Dave Ertman 2019-11-06 91 }
b94b013eb626952 Dave Ertman 2019-11-06 92
a29a912d448dbc9 Avinash Dayanand 2020-02-13 93 if (ice_dcb_bwchk(pf, new_cfg)) {
a29a912d448dbc9 Avinash Dayanand 2020-02-13 94 err = -EINVAL;
a29a912d448dbc9 Avinash Dayanand 2020-02-13 95 goto ets_out;
a29a912d448dbc9 Avinash Dayanand 2020-02-13 96 }
a29a912d448dbc9 Avinash Dayanand 2020-02-13 97
2a87bd73e50d1c7 Dave Ertman 2021-08-06 98 new_cfg->etscfg.maxtcs = pf->hw.func_caps.common_cap.maxtc;
b94b013eb626952 Dave Ertman 2019-11-06 99
b94b013eb626952 Dave Ertman 2019-11-06 100 if (!bwrec)
b94b013eb626952 Dave Ertman 2019-11-06 101 new_cfg->etsrec.tcbwtable[0] = 100;
b94b013eb626952 Dave Ertman 2019-11-06 102
b94b013eb626952 Dave Ertman 2019-11-06 103 err = ice_pf_dcb_cfg(pf, new_cfg, true);
b94b013eb626952 Dave Ertman 2019-11-06 104 /* return of zero indicates new cfg applied */
b94b013eb626952 Dave Ertman 2019-11-06 105 if (err == ICE_DCB_HW_CHG_RST)
b94b013eb626952 Dave Ertman 2019-11-06 106 ice_dcbnl_devreset(netdev);
b94b013eb626952 Dave Ertman 2019-11-06 107 if (err == ICE_DCB_NO_HW_CHG)
b94b013eb626952 Dave Ertman 2019-11-06 108 err = ICE_DCB_HW_CHG_RST;
b94b013eb626952 Dave Ertman 2019-11-06 109
a29a912d448dbc9 Avinash Dayanand 2020-02-13 110 ets_out:
b94b013eb626952 Dave Ertman 2019-11-06 111 mutex_unlock(&pf->tc_mutex);
b94b013eb626952 Dave Ertman 2019-11-06 112 return err;
b94b013eb626952 Dave Ertman 2019-11-06 113 }
b94b013eb626952 Dave Ertman 2019-11-06 114
:::::: The code at line 66 was first introduced by commit
:::::: b94b013eb6269526eeb3768101666ba6f526313e ice: Implement DCBNL support
:::::: TO: Dave Ertman <david.m.ertman@...el.com>
:::::: CC: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
Powered by blists - more mailing lists