[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20211126184831.5d2a3787@md1za8fc.ad001.siemens.net>
Date: Fri, 26 Nov 2021 18:48:31 +0100
From: Henning Schild <henning.schild@...mens.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Linux LED Subsystem <linux-leds@...r.kernel.org>,
Platform Driver <platform-driver-x86@...r.kernel.org>,
linux-watchdog@...r.kernel.org,
Srikanth Krishnakar <skrishnakar@...il.com>,
Jan Kiszka <jan.kiszka@...mens.com>,
Gerd Haeussler <gerd.haeussler.ext@...mens.com>,
Guenter Roeck <linux@...ck-us.net>,
Wim Van Sebroeck <wim@...ux-watchdog.org>,
Mark Gross <mgross@...ux.intel.com>,
Hans de Goede <hdegoede@...hat.com>,
Pavel Machek <pavel@....cz>, Enrico Weigelt <lkml@...ux.net>
Subject: Re: [PATCH v4 2/4] leds: simatic-ipc-leds: add new driver for
Siemens Industial PCs
Am Fri, 26 Nov 2021 17:02:00 +0200
schrieb Andy Shevchenko <andy.shevchenko@...il.com>:
> On Fri, Nov 26, 2021 at 4:10 PM Henning Schild
> <henning.schild@...mens.com> wrote:
> >
> > This driver adds initial support for several devices from Siemens.
> > It is based on a platform driver introduced in an earlier commit.
>
> ...
>
> > +static struct simatic_ipc_led simatic_ipc_leds_mem[] = {
> > + {0x500 + 0x1A0, "red:" LED_FUNCTION_STATUS "-1"},
> > + {0x500 + 0x1A8, "green:" LED_FUNCTION_STATUS "-1"},
> > + {0x500 + 0x1C8, "red:" LED_FUNCTION_STATUS "-2"},
> > + {0x500 + 0x1D0, "green:" LED_FUNCTION_STATUS "-2"},
> > + {0x500 + 0x1E0, "red:" LED_FUNCTION_STATUS "-3"},
> > + {0x500 + 0x198, "green:" LED_FUNCTION_STATUS "-3"},
> > + { }
> > +};
>
> Like I said, this is not okay.
>
> Why can't you simply enable the pinctrl driver and use it?
What do you mean with enable (=m, =y)? The kernel has it built in ...
but it does not come up because it does not find an ACPI table entry
nor a p2sb PCI device.
When with enable you mean ... repair the pinctrl drivers with your
patches, i am afraid i am not qualified and hardly responsible. It is
not "simple" for me. I will test and switch to pinctrl .... but here i
am tired of waiting and pushing/asking to turn the order of patches
around.
Or can i trigger the pinctrl driver to probe from my init/probe?
Henning
Powered by blists - more mailing lists