lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:   Fri, 26 Nov 2021 20:59:26 +0800
From:   kernel test robot <lkp@...el.com>
To:     Hannes Reinecke <hare@...e.de>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [hare-scsi-devel:reserved-tags.v9 16/16]
 drivers/scsi/aacraid/linit.c:705:37: error: 'struct scsi_cmnd' has no member
 named 'request'

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git reserved-tags.v9
head:   b734f6a1dc097d72408e753b7d7022516d7174f4
commit: b734f6a1dc097d72408e753b7d7022516d7174f4 [16/16] aacraid: use scsi_host_busy_iter() to traverse outstanding commands
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20211126/202111262044.rBT6cBSO-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git/commit/?id=b734f6a1dc097d72408e753b7d7022516d7174f4
        git remote add hare-scsi-devel https://git.kernel.org/pub/scm/linux/kernel/git/hare/scsi-devel.git
        git fetch --no-tags hare-scsi-devel reserved-tags.v9
        git checkout b734f6a1dc097d72408e753b7d7022516d7174f4
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arc SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/scsi/aacraid/linit.c: In function 'aac_eh_abort':
>> drivers/scsi/aacraid/linit.c:705:37: error: 'struct scsi_cmnd' has no member named 'request'
     705 |                 fib = &aac->fibs[cmd->request->tag];
         |                                     ^~
   drivers/scsi/aacraid/linit.c:772:45: error: 'struct scsi_cmnd' has no member named 'request'
     772 |                         fib = &aac->fibs[cmd->request->tag];
         |                                             ^~
   drivers/scsi/aacraid/linit.c:786:45: error: 'struct scsi_cmnd' has no member named 'request'
     786 |                         fib = &aac->fibs[cmd->request->tag];
         |                                             ^~
   drivers/scsi/aacraid/linit.c: In function 'aac_eh_bus_reset_iter':
   drivers/scsi/aacraid/linit.c:1006:41: error: 'struct scsi_cmnd' has no member named 'request'
    1006 |         struct fib *fib = &aac->fibs[cmd->request->tag];
         |                                         ^~
   In file included from include/linux/perf_event.h:25,
                    from include/linux/trace_events.h:10,
                    from include/trace/syscall.h:7,
                    from include/linux/syscalls.h:88,
                    from drivers/scsi/aacraid/linit.c:33:
   At top level:
   arch/arc/include/asm/perf_event.h:126:27: warning: 'arc_pmu_cache_map' defined but not used [-Wunused-const-variable=]
     126 | static const unsigned int arc_pmu_cache_map[C(MAX)][C(OP_MAX)][C(RESULT_MAX)] = {
         |                           ^~~~~~~~~~~~~~~~~
   arch/arc/include/asm/perf_event.h:91:27: warning: 'arc_pmu_ev_hw_map' defined but not used [-Wunused-const-variable=]
      91 | static const char * const arc_pmu_ev_hw_map[] = {
         |                           ^~~~~~~~~~~~~~~~~
--
   drivers/scsi/aacraid/commsup.c: In function 'aac_close_sync_fib_iter':
>> drivers/scsi/aacraid/commsup.c:1473:45: error: 'struct scsi_cmnd' has no member named 'request'
    1473 |         struct fib *fib = &aac->fibs[command->request->tag];
         |                                             ^~


vim +705 drivers/scsi/aacraid/linit.c

   680	
   681	static int aac_eh_abort(struct scsi_cmnd* cmd)
   682	{
   683		struct scsi_device * dev = cmd->device;
   684		struct Scsi_Host * host = dev->host;
   685		struct aac_dev * aac = (struct aac_dev *)host->hostdata;
   686		struct fib *fib;
   687		int count;
   688		u32 bus, cid;
   689		int ret = FAILED;
   690	
   691		if (aac_adapter_check_health(aac))
   692			return ret;
   693	
   694		bus = aac_logical_to_phys(scmd_channel(cmd));
   695		cid = scmd_id(cmd);
   696		if (aac->hba_map[bus][cid].devtype == AAC_DEVTYPE_NATIVE_RAW) {
   697			struct aac_hba_tm_req *tmf;
   698			int status;
   699			u64 address;
   700	
   701			pr_err("%s: Host adapter abort request (%d,%d,%d,%d)\n",
   702			       AAC_DRIVERNAME, host->host_no,
   703			       sdev_channel(dev), sdev_id(dev), (int)dev->lun);
   704	
 > 705			fib = &aac->fibs[cmd->request->tag];
   706			if (*(u8 *)fib->hw_fib_va != 0 &&
   707			    (fib->flags & FIB_CONTEXT_FLAG_NATIVE_HBA) &&
   708			    (fib->callback_data == cmd))
   709				ret = SUCCESS;
   710			if (ret == FAILED)
   711				return ret;
   712	
   713			/* start a HBA_TMF_ABORT_TASK TMF request */
   714			fib = aac_fib_alloc(aac, DMA_NONE);
   715			if (!fib)
   716				return ret;
   717	
   718			tmf = (struct aac_hba_tm_req *)fib->hw_fib_va;
   719			memset(tmf, 0, sizeof(*tmf));
   720			tmf->tmf = HBA_TMF_ABORT_TASK;
   721			tmf->it_nexus = aac->hba_map[bus][cid].rmw_nexus;
   722			tmf->lun[1] = cmd->device->lun;
   723	
   724			address = (u64)fib->hw_error_pa;
   725			tmf->error_ptr_hi = cpu_to_le32((u32)(address >> 32));
   726			tmf->error_ptr_lo = cpu_to_le32((u32)(address & 0xffffffff));
   727			tmf->error_length = cpu_to_le32(FW_ERROR_BUFFER_SIZE);
   728	
   729			fib->hbacmd_size = sizeof(*tmf);
   730			cmd->SCp.sent_command = 0;
   731	
   732			status = aac_hba_send(HBA_IU_TYPE_SCSI_TM_REQ, fib,
   733					  (fib_callback) aac_hba_callback,
   734					  (void *) cmd);
   735			if (status != -EINPROGRESS) {
   736				aac_fib_complete(fib);
   737				aac_fib_free(fib);
   738				return ret;
   739			}
   740			/* Wait up to 15 secs for completion */
   741			for (count = 0; count < 15; ++count) {
   742				if (cmd->SCp.sent_command) {
   743					ret = SUCCESS;
   744					break;
   745				}
   746				msleep(1000);
   747			}
   748	
   749			if (ret != SUCCESS)
   750				pr_err("%s: Host adapter abort request timed out\n",
   751				AAC_DRIVERNAME);
   752		} else {
   753			pr_err(
   754				"%s: Host adapter abort request.\n"
   755				"%s: Outstanding commands on (%d,%d,%d,%d):\n",
   756				AAC_DRIVERNAME, AAC_DRIVERNAME,
   757				host->host_no, sdev_channel(dev), sdev_id(dev),
   758				(int)dev->lun);
   759			switch (cmd->cmnd[0]) {
   760			case SERVICE_ACTION_IN_16:
   761				if (!(aac->raw_io_interface) ||
   762				    !(aac->raw_io_64) ||
   763				    ((cmd->cmnd[1] & 0x1f) != SAI_READ_CAPACITY_16))
   764					break;
   765				fallthrough;
   766			case INQUIRY:
   767			case READ_CAPACITY:
   768				/*
   769				 * Mark associated FIB to not complete,
   770				 * eh handler does this
   771				 */
   772				fib = &aac->fibs[cmd->request->tag];
   773				if (fib->hw_fib_va->header.XferState &&
   774				    (fib->flags & FIB_CONTEXT_FLAG) &&
   775				    (fib->callback_data == cmd)) {
   776					fib->flags |= FIB_CONTEXT_FLAG_TIMED_OUT;
   777					cmd->SCp.phase = AAC_OWNER_ERROR_HANDLER;
   778					ret = SUCCESS;
   779				}
   780				break;
   781			case TEST_UNIT_READY:
   782				/*
   783				 * Mark associated FIB to not complete,
   784				 * eh handler does this
   785				 */
   786				fib = &aac->fibs[cmd->request->tag];
   787				if ((fib->hw_fib_va->header.XferState &
   788				     cpu_to_le32(Async | NoResponseExpected)) &&
   789				    (fib->flags & FIB_CONTEXT_FLAG) &&
   790				    (fib->callback_data == cmd)) {
   791					fib->flags |= FIB_CONTEXT_FLAG_TIMED_OUT;
   792					cmd->SCp.phase = AAC_OWNER_ERROR_HANDLER;
   793					ret = SUCCESS;
   794				}
   795				break;
   796			}
   797		}
   798		return ret;
   799	}
   800	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ