linux-kernel - RE: [EXT] [PATCH 1/2] scsi: qedi: Remove set but unused 'page' variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 27 Nov 2021 09:14:51 +0000
From:   Manish Rangankar <mrangankar@...vell.com>
To:     Florian Fainelli <f.fainelli@...il.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:     kernel test robot <lkp@...el.com>,
        Nilesh Javali <njavali@...vell.com>,
        GR-QLogic-Storage-Upstream <GR-QLogic-Storage-Upstream@...vell.com>,
        "James E.J. Bottomley" <jejb@...ux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@...cle.com>,
        "open list:QLOGIC QL41xxx ISCSI DRIVER" <linux-scsi@...r.kernel.org>
Subject: RE: [EXT] [PATCH 1/2] scsi: qedi: Remove set but unused 'page'
 variable

> >>   	list = (u64 *)qedi->bdq_pbl_list;
> >> -	page = qedi->bdq_pbl_list_dma;
> >>   	for (i = 0; i < qedi->bdq_pbl_list_num_entries; i++) {
> >>   		*list = qedi->bdq_pbl_dma;
> >>   		list++;
> >> -		page += QEDI_PAGE_SIZE;
> >>   	}
> >>
> >>   	return 0;
> >> --
> >> 2.25.1
> >
> > Thanks,
> > Acked-by: Manish Rangankar <mrangankar@...vell.com>
> 
> Thanks for taking a look, does not that make the loop iterating the list even
> more useless now, though? Should not page have been used for something in
> that function?
> --

We need list to build structure of bdq list in firmware understandable format.