[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1b733a65-85cc-4afc-6546-dec26334d2cd@suse.de>
Date: Sun, 28 Nov 2021 11:40:58 +0100
From: Hannes Reinecke <hare@...e.de>
To: John Garry <john.garry@...wei.com>, axboe@...nel.dk
Cc: linux-block@...r.kernel.org, linux-kernel@...r.kernel.org,
ming.lei@...hat.com, kashyap.desai@...adcom.com
Subject: Re: [PATCH RFT 2/3] blk-mq: Delete busy_iter_fn
On 11/2/21 12:27 PM, John Garry wrote:
> Typedefs busy_iter_fn and busy_tag_iter_fn are now identical, so delete
> busy_iter_fn to reduce duplication.
>
> It would be nicer to delete busy_tag_iter_fn, as the name busy_iter_fn is
> less specific.
>
> However busy_tag_iter_fn is used in many different parts of the tree,
> unlike busy_iter_fn which is just use in block/, so just take the
> straightforward path now, so that we could rename later treewide.
>
> Signed-off-by: John Garry <john.garry@...wei.com>
> ---
> block/blk-mq-tag.c | 6 +++---
> block/blk-mq-tag.h | 2 +-
> include/linux/blk-mq.h | 1 -
> 3 files changed, 4 insertions(+), 5 deletions(-)
>
Reviewed-by: Hannes Reinecke <hare@...e.de>
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@...e.de +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer
Powered by blists - more mailing lists