linux-kernel - RE: [PATCH] mei: Remove some dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <17d6896a6abf49138556e34cb426d575@intel.com>
Date:   Sun, 28 Nov 2021 11:12:33 +0000
From:   "Winkler, Tomas" <tomas.winkler@...el.com>
To:     Haakon Bugge <haakon.bugge@...cle.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>
CC:     "arnd@...db.de" <arnd@...db.de>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        OFED mailing list <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH] mei: Remove some dead code


> 
> 
> > On 12 Nov 2021, at 11:06, Christophe JAILLET
> <christophe.jaillet@...adoo.fr> wrote:
> >
> > 'generated' is known to be true here, so "true || whatever" will still
> > be true.
> >
> > So, remove some dead code.
> >
> > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> > ---
> > This is also likely that a bug is lurking here.
> >
> > Maybe, the following was expected:
> > -	generated = generated ||
> > +	generated =
> > 		(hisr & HISR_INT_STS_MSK) ||
> > 		(ipc_isr & SEC_IPC_HOST_INT_STATUS_PENDING);
> >
> > ?
> 
> I concur about your analysis, but I do not know the intent here.
Your fix  is okay, I can ack that patch. 
Thanks
Tomas

> 
> 
> Håkon
> 
> > ---
> > drivers/misc/mei/hw-txe.c | 6 +-----
> > 1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/drivers/misc/mei/hw-txe.c b/drivers/misc/mei/hw-txe.c
> > index a4e854b9b9e6..00652c137cc7 100644
> > --- a/drivers/misc/mei/hw-txe.c
> > +++ b/drivers/misc/mei/hw-txe.c
> > @@ -994,11 +994,7 @@ static bool mei_txe_check_and_ack_intrs(struct
> mei_device *dev, bool do_ack)
> > 		hhisr &= ~IPC_HHIER_SEC;
> > 	}
> >
> > -	generated = generated ||
> > -		(hisr & HISR_INT_STS_MSK) ||
> > -		(ipc_isr & SEC_IPC_HOST_INT_STATUS_PENDING);
> > -
> > -	if (generated && do_ack) {
> > +	if (do_ack) {
> > 		/* Save the interrupt causes */
> > 		hw->intr_cause |= hisr & HISR_INT_STS_MSK;
> > 		if (ipc_isr & SEC_IPC_HOST_INT_STATUS_IN_RDY)
> > --
> > 2.30.2
> >