linux-kernel - Re: [PATCH] mei: Remove some dead code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YaOSQrGqogbFGAqJ@kroah.com>
Date:   Sun, 28 Nov 2021 15:29:22 +0100
From:   "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:     "Winkler, Tomas" <tomas.winkler@...el.com>
Cc:     Haakon Bugge <haakon.bugge@...cle.com>,
        Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        "arnd@...db.de" <arnd@...db.de>,
        OFED mailing list <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH] mei: Remove some dead code

On Sun, Nov 28, 2021 at 11:12:33AM +0000, Winkler, Tomas wrote:
> 
> > 
> > 
> > > On 12 Nov 2021, at 11:06, Christophe JAILLET
> > <christophe.jaillet@...adoo.fr> wrote:
> > >
> > > 'generated' is known to be true here, so "true || whatever" will still
> > > be true.
> > >
> > > So, remove some dead code.
> > >
> > > Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> > > ---
> > > This is also likely that a bug is lurking here.
> > >
> > > Maybe, the following was expected:
> > > -	generated = generated ||
> > > +	generated =
> > > 		(hisr & HISR_INT_STS_MSK) ||
> > > 		(ipc_isr & SEC_IPC_HOST_INT_STATUS_PENDING);
> > >
> > > ?
> > 
> > I concur about your analysis, but I do not know the intent here.
> Your fix  is okay, I can ack that patch. 

Is that an ack of this patch?  If so, please provide that...

thanks,

greg k-h