linux-kernel - RE: [PATCH v2] acpi/tables: Add AEST in ACPI Table Definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 28 Nov 2021 23:54:09 +0000
From:   "ishii.shuuichir@...itsu.com" <ishii.shuuichir@...itsu.com>
To:     'Hanjun Guo' <guohanjun@...wei.com>,
        "rafael@...nel.org" <rafael@...nel.org>,
        "lenb@...nel.org" <lenb@...nel.org>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
        "sudeep.holla@....com" <sudeep.holla@....com>
CC:     "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "ishii.shuuichir@...itsu.com" <ishii.shuuichir@...itsu.com>
Subject: RE: [PATCH v2] acpi/tables: Add AEST in ACPI Table Definition

Hi, Hanjun.

Thank you for your comment.
We apologize for the basic mistake.

We will try to fix it as follows, is it OK?

---
Subject: [PATCH v3] acpi/tables: Add AEST in ACPI Table Definition

When We added AEST using the Upgrading ACPI tables via initrd function,
the kernel could not recognize the AEST, so added the AEST table to
the list to enable the table upgrade function.

Signed-off-by: Shuuichirou Ishii <ishii.shuuichir@...itsu.com>
---
v3 : Changed the location of the change log so that it does not
     disappear when the patch is applied.

v2 : The reason for committing in the commit log was not clear,
     so it was pointed out and corrected.

 drivers/acpi/tables.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c
index 71419eb16e09..2699bf7e21ab 100644
--- a/drivers/acpi/tables.c
+++ b/drivers/acpi/tables.c
@@ -500,7 +500,7 @@ static const char table_sigs[][ACPI_NAMESEG_SIZE] __initconst = {
    ACPI_SIG_WDDT, ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT,
    ACPI_SIG_PSDT, ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT,
    ACPI_SIG_IORT, ACPI_SIG_NFIT, ACPI_SIG_HMAT, ACPI_SIG_PPTT,
-   ACPI_SIG_NHLT };
+   ACPI_SIG_NHLT, ACPI_SIG_AEST };

 #define ACPI_HEADER_SIZE sizeof(struct acpi_table_header)

--

Best regards,
Shuuichrou.

> -----Original Message-----
> From: Hanjun Guo <guohanjun@...wei.com>
> Sent: Saturday, November 27, 2021 12:01 PM
> To: Ishii, Shuuichirou/石井 周一郎 <ishii.shuuichir@...itsu.com>;
> rafael@...nel.org; lenb@...nel.org; linux-acpi@...r.kernel.org;
> linux-kernel@...r.kernel.org; lorenzo.pieralisi@....com;
> sudeep.holla@....com
> Cc: linux-arm-kernel@...ts.infradead.org
> Subject: Re: [PATCH v2] acpi/tables: Add AEST in ACPI Table Definition
> 
> On 2021/11/25 16:32, Shuuichirou Ishii wrote:
> > When We added AEST using the Upgrading ACPI tables via initrd
> > function, the kernel could not recognize the AEST, so added the AEST
> > table to the list to enable the table upgrade function.
> >
> > Change log:
> > v2 : The reason for committing in the commit log was not clear,
> >       so it was pointed out and corrected.
> 
> Please remove the change log in the commit message.
> 
> >
> > Signed-off-by: Shuuichirou Ishii <ishii.shuuichir@...itsu.com>
> > ---
> 
> You can put the change log here then it will be removed when applying this patch.
> 
> Thanks
> Hanjun