linux-kernel - Re: [patch 05/22] genirq/msi: Fixup includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87tufud4m3.ffs@tglx>
Date:   Mon, 29 Nov 2021 22:38:44 +0100
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Cédric Le Goater <clg@...d.org>,
        LKML <linux-kernel@...r.kernel.org>
Cc:     linux-hyperv@...r.kernel.org, Paul Mackerras <paulus@...ba.org>,
        sparclinux@...r.kernel.org, Wei Liu <wei.liu@...nel.org>,
        Ashok Raj <ashok.raj@...el.com>, Marc Zygnier <maz@...nel.org>,
        x86@...nel.org, Christian Borntraeger <borntraeger@...ibm.com>,
        Bjorn Helgaas <helgaas@...nel.org>,
        Jason Gunthorpe <jgg@...dia.com>, linux-pci@...r.kernel.org,
        xen-devel@...ts.xenproject.org, ath11k@...ts.infradead.org,
        Kevin Tian <kevin.tian@...el.com>,
        Heiko Carstens <hca@...ux.ibm.com>,
        Alex Williamson <alex.williamson@...hat.com>,
        Megha Dey <megha.dey@...el.com>,
        Juergen Gross <jgross@...e.com>,
        Thomas Bogendoerfer <tsbogend@...ha.franken.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-mips@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [patch 05/22] genirq/msi: Fixup includes

Cedric,

On Mon, Nov 29 2021 at 08:33, Cédric Le Goater wrote:
> On 11/27/21 02:18, Thomas Gleixner wrote:
>> Remove the kobject.h include from msi.h as it's not required and add a
>> sysfs.h include to the core code instead.
>> 
>> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
>
>
> This patch breaks compile on powerpc :
>
>    CC      arch/powerpc/kernel/msi.o
> In file included from ../arch/powerpc/kernel/msi.c:7:
> ../include/linux/msi.h:410:65: error: ‘struct cpumask’ declared inside parameter list will not be visible outside of this definition or declaration [-Werror]
>    410 | int msi_domain_set_affinity(struct irq_data *data, const struct cpumask *mask,
>        |                                                                 ^~~~~~~
> cc1: all warnings being treated as errors
>
> Below is fix you can merge in patch 5.

thanks for having a look. I fixed up this and other fallout and pushed out an
updated series (all 4 parts) to:

        git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel msi

Thanks,

        tglx