linux-kernel - Re: [PATCH v2] docs: admin-guide/blockdev: Remove digraph of node-states

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87sfvesktm.fsf@meer.lwn.net>
Date:   Mon, 29 Nov 2021 14:39:33 -0700
From:   Jonathan Corbet <corbet@....net>
To:     Akira Yokosawa <akiyks@...il.com>,
        Joel Colledge <joel.colledge@...bit.com>
Cc:     Philipp Reisner <philipp.reisner@...bit.com>,
        Lars Ellenberg <lars.ellenberg@...bit.com>,
        drbd-dev@...ts.linbit.com, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] docs: admin-guide/blockdev: Remove digraph of
 node-states

Akira Yokosawa <akiyks@...il.com> writes:

> While node-states-8.dot has two digraphs, the dot(1) command can
> not properly handle multiple graphs in a DOT file and the
> kernel-doc page at
>
>     https://www.kernel.org/doc/html/latest/admin-guide/blockdev/drbd/figures.html
>
> fails to render the graphs.
>
> It turned out that the digraph of node_states can be removed.
>
> Quote from Joel's reflection:
>
>     On reflection, the digraph node_states can be removed entirely.
>     It is too basic to contain any useful information. In addition
>     it references "ioctl_set_state". The ioctl configuration
>     interface for DRBD has long been removed. In fact, it was never
>     in the upstream version of DRBD.
>
> Remove node_states and rename the DOT file peer_states-8.dot.
>
> Suggested-by: Joel Colledge <joel.colledge@...bit.com>
> Signed-off-by: Akira Yokosawa <akiyks@...il.com>
> Cc: Philipp Reisner <philipp.reisner@...bit.com>
> Cc: Lars Ellenberg <lars.ellenberg@...bit.com>

Applied, thanks.

jon