linux-kernel - [PATCH v3] rtc: da9063: add as wakeup source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20211129072650.22686-1-nikita.shubin@maquefel.me>
Date:   Mon, 29 Nov 2021 10:26:49 +0300
From:   Nikita Shubin <nikita.shubin@...uefel.me>
To:     unlisted-recipients:; (no To-header on input)
Cc:     Adam Thomson <Adam.Thomson.Opensource@...semi.com>,
        David Abdurachmanov <david.abdurachmanov@...ive.com>,
        Nikita Shubin <nikita.shubin@...uefel.me>,
        Support Opensource <support.opensource@...semi.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH v3] rtc: da9063: add as wakeup source

As da9063 RTC is not a real I2C client, but relies on da9063 MFD 
driver, we need to explicitly mark da9063 RTC as a wakeup source 
to be able to access class/rtc/rtcN/wakealarm sysfs entry 
to set alarms, so we can wakeup from SHUTDOWN/RTC/DELIVERY mode.

As da9063 driver refuses to load without irq, we simply add it 
as a wakeup source before registering rtc device.

Signed-off-by: Nikita Shubin <nikita.shubin@...uefel.me>
---
v2->v3:
Adam Thomson:
Commit message more verbose.
---
 drivers/rtc/rtc-da9063.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/rtc/rtc-da9063.c b/drivers/rtc/rtc-da9063.c
index d4b72a9fa2ba..b9a73356bace 100644
--- a/drivers/rtc/rtc-da9063.c
+++ b/drivers/rtc/rtc-da9063.c
@@ -494,6 +494,8 @@ static int da9063_rtc_probe(struct platform_device *pdev)
 		dev_err(&pdev->dev, "Failed to request ALARM IRQ %d: %d\n",
 			irq_alarm, ret);
 
+	device_init_wakeup(&pdev->dev, true);
+
 	return devm_rtc_register_device(rtc->rtc_dev);
 }
 
-- 
2.31.1