linux-kernel - RE: [PATCH v3] rtc: da9063: add as wakeup source

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB9PR10MB4652F8B0DD6D4294276CFCB980669@DB9PR10MB4652.EURPRD10.PROD.OUTLOOK.COM>
Date:   Mon, 29 Nov 2021 11:03:56 +0000
From:   Adam Thomson <Adam.Thomson.Opensource@...semi.com>
To:     Nikita Shubin <nikita.shubin@...uefel.me>
CC:     Adam Thomson <Adam.Thomson.Opensource@...semi.com>,
        David Abdurachmanov <david.abdurachmanov@...ive.com>,
        Support Opensource <Support.Opensource@...semi.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        "linux-rtc@...r.kernel.org" <linux-rtc@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v3] rtc: da9063: add as wakeup source

On 29 November 2021 07:27, Nikita Shubin wrote:

> As da9063 RTC is not a real I2C client, but relies on da9063 MFD
> driver, we need to explicitly mark da9063 RTC as a wakeup source
> to be able to access class/rtc/rtcN/wakealarm sysfs entry
> to set alarms, so we can wakeup from SHUTDOWN/RTC/DELIVERY mode.
> 
> As da9063 driver refuses to load without irq, we simply add it
> as a wakeup source before registering rtc device.
> 
> Signed-off-by: Nikita Shubin <nikita.shubin@...uefel.me>
> ---

Thanks for the update.

Reviewed-by: Adam Thomson <Adam.Thomson.Opensource@...semi.com>