[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <163818272249.17830.17168660847837194015.kvalo@codeaurora.org>
Date: Mon, 29 Nov 2021 10:45:28 +0000 (UTC)
From: Kalle Valo <kvalo@...eaurora.org>
To: Kees Cook <keescook@...omium.org>
Cc: Jouni Malinen <j@...fi>, Kees Cook <keescook@...omium.org>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Lee Jones <lee.jones@...aro.org>,
Allen Pais <allen.lkml@...il.com>,
Romain Perier <romain.perier@...il.com>,
Arnd Bergmann <arnd@...db.de>,
Vaibhav Gupta <vaibhavgupta40@...il.com>,
Cong Wang <xiyou.wangcong@...il.com>,
Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org,
netdev@...r.kernel.org, linux-hardening@...r.kernel.org
Subject: Re: [PATCH v2] intersil: Use struct_group() for memcpy() region
Kees Cook <keescook@...omium.org> wrote:
> In preparation for FORTIFY_SOURCE performing compile-time and run-time
> field bounds checking for memcpy(), memmove(), and memset(), avoid
> intentionally writing across neighboring fields.
>
> Use struct_group() in struct hfa384x_tx_frame around members
> frame_control, duration_id, addr1, addr2, addr3, and seq_ctrl, so they
> can be referenced together. This will allow memcpy() and sizeof() to
> more easily reason about sizes, improve readability, and avoid future
> warnings about writing beyond the end of frame_control.
>
> "pahole" shows no size nor member offset changes to struct
> hfa384x_tx_frame. "objdump -d" shows no object code changes.
>
> Signed-off-by: Kees Cook <keescook@...omium.org>
Patch applied to wireless-drivers-next.git, thanks.
601d2293e27f intersil: Use struct_group() for memcpy() region
--
https://patchwork.kernel.org/project/linux-wireless/patch/20211119004646.2347920-1-keescook@chromium.org/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Powered by blists - more mailing lists