[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20211130080924.266116-1-manivannan.sadhasivam@linaro.org>
Date: Tue, 30 Nov 2021 13:39:24 +0530
From: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To: lorenzo.pieralisi@....com, bhelgaas@...gle.com
Cc: svarbanov@...sol.com, bjorn.andersson@...aro.org, robh@...nel.org,
linux-pci@...r.kernel.org, linux-arm-msm@...r.kernel.org,
linux-kernel@...r.kernel.org,
Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
kernel test robot <lkp@...el.com>,
Krzysztof Wilczyński <kw@...ux.com>
Subject: [PATCH v3] PCI: qcom: Use __be16 type to store return value from cpu_to_be16()
cpu_to_be16() returns __be16 value but the driver uses u16 and that's
incorrect. Fix it by using __be16 as the data type of bdf_be variable.
The issue was spotted by the below sparse warning:
sparse warnings: (new ones prefixed by >>)
>> drivers/pci/controller/dwc/pcie-qcom.c:1305:30: sparse: sparse: incorrect type in initializer (different base types) @@ expected unsigned short [usertype] bdf_be @@ got restricted __be16 [usertype] @@
drivers/pci/controller/dwc/pcie-qcom.c:1305:30: sparse: expected unsigned short [usertype] bdf_be
drivers/pci/controller/dwc/pcie-qcom.c:1305:30: sparse: got restricted __be16 [usertype]
Reported-by: kernel test robot <lkp@...el.com>
Reviewed-by: Krzysztof Wilczyński <kw@...ux.com>
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
---
Changes in v3:
* Added Krzysztof's reviewed-by tag and modified the commit message as per
his comments
Changes in v2:
* Modified the commit message and subject to describe the actual issue
as per comments from Bjorn.
drivers/pci/controller/dwc/pcie-qcom.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pci/controller/dwc/pcie-qcom.c b/drivers/pci/controller/dwc/pcie-qcom.c
index 1c3d1116bb60..ddecd7f341c5 100644
--- a/drivers/pci/controller/dwc/pcie-qcom.c
+++ b/drivers/pci/controller/dwc/pcie-qcom.c
@@ -1343,7 +1343,7 @@ static int qcom_pcie_config_sid_sm8250(struct qcom_pcie *pcie)
/* Look for an available entry to hold the mapping */
for (i = 0; i < nr_map; i++) {
- u16 bdf_be = cpu_to_be16(map[i].bdf);
+ __be16 bdf_be = cpu_to_be16(map[i].bdf);
u32 val;
u8 hash;
--
2.25.1
Powered by blists - more mailing lists