linux-kernel - Re: [PATCH v3] PCI: qcom: Use __be16 type to store return value from cpu_to

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <163878663178.16251.482948854423649218.b4-ty@arm.com>
Date:   Mon,  6 Dec 2021 10:31:02 +0000
From:   Lorenzo Pieralisi <lorenzo.pieralisi@....com>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        bhelgaas@...gle.com
Cc:     Lorenzo Pieralisi <lorenzo.pieralisi@....com>, robh@...nel.org,
        linux-kernel@...r.kernel.org, linux-arm-msm@...r.kernel.org,
        Krzysztof Wilczyński <kw@...ux.com>,
        linux-pci@...r.kernel.org, svarbanov@...sol.com,
        kernel test robot <lkp@...el.com>, bjorn.andersson@...aro.org
Subject: Re: [PATCH v3] PCI: qcom: Use __be16 type to store return value from cpu_to_be16()

On Tue, 30 Nov 2021 13:39:24 +0530, Manivannan Sadhasivam wrote:
> cpu_to_be16() returns __be16 value but the driver uses u16 and that's
> incorrect. Fix it by using __be16 as the data type of bdf_be variable.
> 
> The issue was spotted by the below sparse warning:
> 
> sparse warnings: (new ones prefixed by >>)
> >> drivers/pci/controller/dwc/pcie-qcom.c:1305:30: sparse: sparse: incorrect type in initializer (different base types) @@     expected unsigned short [usertype] bdf_be @@     got restricted __be16 [usertype] @@
>    drivers/pci/controller/dwc/pcie-qcom.c:1305:30: sparse:     expected unsigned short [usertype] bdf_be
>    drivers/pci/controller/dwc/pcie-qcom.c:1305:30: sparse:     got restricted __be16 [usertype]
> 
> [...]

Applied to pci/qcom, thanks!

[1/1] PCI: qcom: Use __be16 type to store return value from cpu_to_be16()
      https://git.kernel.org/lpieralisi/pci/c/3f13d611aa

Thanks,
Lorenzo